-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] v1.0.0 / v0.14.0 #253
Merged
Merged
Changes from 93 commits
Commits
Show all changes
106 commits
Select commit
Hold shift + click to select a range
8104fdd
getExpiration returns CurrentTime for empty record
tedivm 3b169d1
Created stand alone "save" function that uses the data and ttl proper…
tedivm d7be6c8
Formatting
tedivm fc59507
Decoupled "set" function from persisting values
tedivm 94735f2
Removed expiration time for `set` function
tedivm 1c7f102
Split invalidation method from get function.
tedivm 6a8f49e
Fixed formatting
tedivm 56633a3
Fixed more "save" related changes
tedivm 719d597
Typo/syntax error
tedivm de27992
Added save function to ItemInterface
tedivm 2c5b04e
Changed `getItemIterator` to `getItems`
tedivm 7c573de
Added commit, saveDeferred, save, and deleteItems to the Pool Interface
tedivm 10b18d8
Fixed formatting
tedivm 1ec6126
Merge branch 'master' into psr6
tedivm 84e2638
Extend from RuntimeException
tedivm 5f50f70
Stopped "collecting" deleted items
tedivm cbf4723
Added isHit function
tedivm 3087701
Added "exists" function
tedivm 44fd506
Made expiresAt throw InvalidArgumentException on non-datetime arguments
tedivm ee777fa
Formatting
tedivm 072bae1
Added PSR-6 additions to changelog
tedivm f8f7e5a
Rejiggered the exists function
tedivm 5d24d2b
Documented Interfaces
tedivm ad8bf39
Added DateTime php5.4 compatibility fix
tedivm e95926f
Fixed formatting and exists signature
tedivm 373420f
Removed unused method "setDriver"
tedivm 0ccae48
Added additional expiration tests
tedivm b35808a
formatting
tedivm 3aef95a
Switched datetime test for compatibility with <php5.5
tedivm d912ae0
Changed exception test to handle php7 TypeError
tedivm 94ee353
Formatting
tedivm 6268499
Added php5.4 datetime compatibility
tedivm 0471deb
Removed dead code path
tedivm e901c39
Added additional testing of the pool class.
tedivm ca7ee3f
Merge pull request #252 from tedious/psr6
tedivm 1f410e3
Removed SQLite2
tedivm 711f5d9
Fixed SqlitePDO class
tedivm 3a63888
Updated changelog- removed sqlite3
tedivm 975fbae
Merge pull request #255 from tedious/sqlite_upgrades
tedivm 58e716f
Install apcu-beta for apc testing
tedivm 3a2bd4d
Fixed comparison format
tedivm dacc1b9
Replaced check for apc extension with check for apc_fetch function
tedivm 1de9efa
Removed pac extension as the pecl command adds it to php.ini
tedivm f03ec63
Manually adding apache extension to php.ini
tedivm 4687cb6
Added apc.so back to php5.4 build
tedivm 140f841
Another attempt to make travis use the apcu and apc extensions
tedivm d8d2867
Removed useless addition of apcu extension
tedivm e9131f6
Split travis-ci php config by version
tedivm 57b14eb
Added "isPersistent" test
tedivm 5ae98e8
Merge pull request #256 from tedious/apc_travis
tedivm a5a8a20
Testing changes to apcu extension for travis ci
tedivm cfa2b05
Removed apache extension (again), since pecl also adds it
tedivm cac1f2d
Upgraded phpunit to 4.8
tedivm 4967814
Test Redit Socket
tedivm e1bfa34
fixed syntax, yelled at editor
tedivm d266c03
Changed redis socket permissions
tedivm 26b9bb8
Added check for throwable in test suite - php7 compatibility
tedivm 9dc90ad
Formatting
tedivm a1ae6c9
Test invalid encoder
tedivm 3694988
Improved Filesystem Encoder testing.
tedivm d927983
Additional Utilities class testing
tedivm bce7ac9
Tightened up code paths
tedivm fff6b59
Tested driver filtering
tedivm d56e636
Test UnavailableDriver exception in AbstractDriver
tedivm 768d30a
Improved composite driver testing.
tedivm 0b85b73
Formatting
tedivm 29262c3
Removed dead code
tedivm bd717b5
Introduced numeric encoding return to streamline filesystem driver
tedivm 2c103fd
Preset the expiration variable
tedivm 5244e31
Set SQLite driver to throw errors on failed driver creation
tedivm 6e0dda6
Improved testing of invalid memcache options
tedivm 1cc6313
Added "use" statement for Memcache driver
tedivm 292f78d
Fixed option name
tedivm 503a3a5
Merge pull request #257 from tedious/testing
tedivm 1d615c9
Removed deprecated constants
tedivm 4e17819
Removed deprecated DriverList::getDrivers function.
tedivm 284e8a3
Merge pull request #258 from tedious/deprecation
tedivm 04441c4
Added deprecation notices to changelog
tedivm d4b0d3c
Merge branch 'master' into v1.0.0-dev
tedivm 18f1912
Brought Stash up to date with the latest PSR-6 draft
tedivm 44400d7
Merge pull request #264 from tedious/psr6-update
tedivm 9e98a36
Fixed documentation and signatures
tedivm 07a6a82
Fixed signature.
tedivm ad873c2
simplified options check
tedivm a4e8306
Merge branch 'master' into v1.0.0-dev
tedivm 080bdf0
Merge branch 'master' into v1.0.0-dev
tedivm bedb7d1
Merge branch 'master' into v1.0.0-dev
tedivm 5ebe4bc
Updated with PSR-6 changes
tedivm 874a8e4
Added pecl support for php7 testing
tedivm 05586c6
Lock apache version for php < 7
tedivm 5b59455
Removed "beta" preference for apcu
tedivm 555b410
Removed "beta" label from apcu install
tedivm 8935d3f
Merge branch 'testing_php7' into v1.0.0-dev
tedivm 40ee61f
Removed legacy key styles (array, arbitrary arguments)
tedivm 6b8c33d
Implimented from PSR-6 interfaces
tedivm 00bcc6b
Added APCU support.
tedivm 0976fab
Fixed iterator class
tedivm 1a9c755
Removed `Driver::setOptions($options)` in favor of `Driver::construct…
tedivm 238658d
Removed more setOptions calls
tedivm 6a51789
fix issue with different constructor for APCu
limenet 616b48c
Merge pull request #276 from limenet/v1.0.0-dev
tedivm 1a4d650
Add apcu extension to testing ini files
tedivm 209c213
Fixed apcu function parameters
tedivm 5b4ecaa
Removed sqlite2 support
tedivm 6415e06
Moved filesystem checks to parent driver
tedivm b10e2f5
Merge branch 'master' into v1.0.0-dev, resolving conflicts
tedivm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,5 +28,3 @@ services: | |
|
||
matrix: | ||
fast_finish: true | ||
allow_failures: | ||
- php: 7.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this sound strange, I wouldn't expect a unset expiry to mean it has expired (now). As this is currently not part of the PSR interface, maybe rather return null if none is set.
Otherwise expiry should probably have been on the
pool->save( $item, $ttl )
methodThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a problem making this return null- it originally returned false, but when getExpiration was added to the PSR they had their version return the current datetime. Now that it's been removed from the standard we can handle it however we want, so I'll put it back to null.