-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temp fixes #106
Merged
Merged
Temp fixes #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed all the formating and oil calculations. Fairly robust now. Tested in couple of drives (e46) seems solid. |
tedsalmon
previously approved these changes
Dec 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! :)
Are you trying to resolve the conflict? I could look at it so nothing gets missed in the process.
Sometime just a level of conditional block make a lot of difference. So I can look at it if you want.
Ivan Debnar
+44 7539 485371
+421 905 404033
… On 7 Dec 2021, at 16:09, Ted Salmon ***@***.***> wrote:
@tedsalmon approved this pull request.
Thank you so much! :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#106 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABPC6GQO6RE64Z3EMF6ATLUPYWULANCNFSM5I4SS2FQ>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
@nabucho -- Thanks but no worries, I got it :) |
tedsalmon
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oil, display, etc....