Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose in guests.yaml the provisioned HW setup to support <partitions> Beaker XML element #2402

Open
thrix opened this issue Oct 13, 2023 · 4 comments
Assignees
Labels
area | hardware Implementation of hardware requirements step | provision Stuff related to the provision step

Comments

@thrix
Copy link
Collaborator

thrix commented Oct 13, 2023

In some cases, it would be handy if the user would be able to read the hardware that was provisioned to do additional setup in the prepare phase.

For example, the user could ask for X block devices to be created and would be able to detect their

This could help to implement more generally part of the use cases for the <partitions> element in the Beaker XML format.

https://beaker-project.org/docs/user-guide/customizing-partitions.html

Note that this would not help with modifying the root partition, but for that we already have the kickstart field.

Kernel QE requirement: https://issues.redhat.com/browse/KQE-49
Testing Farm Jira: TBD

@thrix thrix added step | provision Stuff related to the provision step area | hardware Implementation of hardware requirements labels Oct 13, 2023
@thrix
Copy link
Collaborator Author

thrix commented Oct 13, 2023

This seems a different approach as with #1835 proposal which would require tmt execution support.

@happz
Copy link
Collaborator

happz commented Oct 13, 2023

It probably makes no sense to describe every property of the guest, it could easily turn into some kind of Beaker inventory script.

  • I'd like to follow the existing HW specification from https://tmt.readthedocs.io/en/stable/spec/hardware.html
  • only fields for which we define extra "runtime manifest" fields would be added
  • sometimes we could be able to re-use the HW specification key directly, for some properties we will need to add some, I guess:
# Requested:
hardware:
  disk:
    - size: "120 GiB"
    - size: "256 GiB"
    - size: "512 GiB"
  virtualization:
    hypervisor: != xen

# Something like this we could emit into a "manifest file":
hardware:
  disk:
    - block-device: /dev/vda
    - block-device: /dev/vdb
    - block-device: /dev/vdc
  virtualization:
    hypervisor: nitro

@happz
Copy link
Collaborator

happz commented Oct 13, 2023

And the link to guest topology describing what tmt knows about guests: https://tmt.readthedocs.io/en/stable/spec/plans.html#guest-topology-format

happz added a commit that referenced this issue Dec 31, 2023
Related to #2402. The patch
bootstraps `hardware` field in the guest topology content, and populates
it it very basic content. Extending it with more info, e.g. `disk` or
`system`, will be task for future patches.
happz added a commit that referenced this issue Dec 31, 2023
Related to #2402. The patch
bootstraps `hardware` field in the guest topology content, and populates
it it very basic content. Extending it with more info, e.g. `disk` or
`system`, will be task for future patches.
happz added a commit that referenced this issue Mar 20, 2024
Related to #2402. The patch
bootstraps `hardware` field in the guest topology content, and
populates it it very basic content. Extending it with more info,
e.g. `disk` or `system`, will be task for future patches.
@happz
Copy link
Collaborator

happz commented Mar 20, 2024

One blocking issue for virtual aka testcloud, https://pagure.io/testcloud/issue/164

happz added a commit that referenced this issue Mar 27, 2024
Related to #2402. The patch
bootstraps `hardware` field in the guest topology content, and
populates it it very basic content. Extending it with more info,
e.g. `disk` or `system`, will be task for future patches.
happz added a commit that referenced this issue Mar 27, 2024
Adds a new key, `block-device`, that guest topology may use to inform
tests about which disk matches requested by HW requirements.

Related to #2402
@happz happz self-assigned this Mar 27, 2024
happz added a commit that referenced this issue Apr 2, 2024
Related to #2402. The patch
bootstraps `hardware` field in the guest topology content, and
populates it it very basic content. Extending it with more info,
e.g. `disk` or `system`, will be task for future patches.
happz added a commit that referenced this issue May 21, 2024
Adds a new key, `block-device`, that guest topology may use to inform
tests about which disk matches requested by HW requirements.

Related to #2402
happz added a commit that referenced this issue May 21, 2024
Related to #2402. The patch
bootstraps `hardware` field in the guest topology content, and
populates it it very basic content. Extending it with more info,
e.g. `disk` or `system`, will be task for future patches.
happz added a commit that referenced this issue May 28, 2024
Adds a new key, `block-device`, that guest topology may use to inform
tests about which disk matches requested by HW requirements.

Related to #2402
happz added a commit that referenced this issue May 28, 2024
Adds a new key, `block-device`, that guest topology may use to inform
tests about which disk matches requested by HW requirements.

Related to #2402
happz added a commit that referenced this issue May 28, 2024
Adds a new key, `block-device`, that guest topology may use to inform
tests about which disk matches requested by HW requirements.

Related to #2402
happz added a commit that referenced this issue Jun 2, 2024
Adds a new key, `block-device`, that guest topology may use to inform
tests about which disk matches requested by HW requirements.

Related to #2402
happz added a commit that referenced this issue Jun 3, 2024
Related to #2402. The patch
bootstraps `hardware` field in the guest topology content, and
populates it it very basic content. Extending it with more info,
e.g. `disk` or `system`, will be task for future patches.
The-Mule pushed a commit to The-Mule/tmt that referenced this issue Oct 14, 2024
Adds a new key, `block-device`, that guest topology may use to inform
tests about which disk matches requested by HW requirements.

Related to teemtee#2402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area | hardware Implementation of hardware requirements step | provision Stuff related to the provision step
Projects
None yet
Development

No branches or pull requests

2 participants