Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEIID-5563 pulling module dependency out of the client #1110

Merged
merged 2 commits into from
Dec 17, 2018

Conversation

shawkins
Copy link
Contributor

No description provided.

resource Connection removed from interfaces
consolidated file related logic, removes vfs from translator
creates a new module for the resource adapter spi
creates a thin api replacement for
WrappedConnection/Connection/ConnectionFactory
@rareddy
Copy link
Member

rareddy commented Dec 15, 2018

Looks good, The file related ones I did not look closely. Looking back at my code the one thing I did was like

` public interface SourceConnectionFactory<T extends SourceConnection, C extends
SourceConfiguration> extends Serializable {

void configure(C config) throws SourceException;

T getConnection() throws SourceException;

}`
to bring the configuration into it, but in hindsight I like the way you have now, as it would not be feasible to agree on configuration in every runtime.

@shawkins
Copy link
Contributor Author

but in hindsight I like the way you have now, as it would not be feasible to agree on configuration in every runtime.

Yes, I see that as a separate concern.

I'll commit this then and update the dev docs where appropriate.

@shawkins shawkins merged commit 7b80f97 into teiid:master Dec 17, 2018
@shawkins
Copy link
Contributor Author

shawkins commented Dec 17, 2018

Part of the motivation of the file changes was to better isolate the VFS dependency, but I realize that is not a strong rationale as VFS is still a dependency of the engine and runtime.

The change also does not fully remove the usage of the resource dependency - it is still required in the engine for the transactional/thread logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants