TEIID-5826: Adding ability to read length, precision and scale from m…

[rareddy]

…etadata properties for OData V2, and SAP transaltors

[shawkins]

An issue would be that we have some inconsistency between the notion of odata precision and teiid precision - OData timestamp precision = Teiid Timestamp scale. See

teiid/olingo/src/main/java/org/teiid/olingo/service/ODataSchemaBuilder.java

Line 204 in 5df9a3f

} else if (runtimeType.equals(DataTypeManager.DefaultDataTypes.TIMESTAMP)) {

For the other non-numeric types precision isn't needed at all, but it should be okay to set it on them.

[rareddy]

BTW, this is OData V2 only, do we know if that mismatch exists here also?

Build error seems to be unrelated.

[shawkins]

Yes, it looks like it: https://github.com/apache/olingo-odata2/blob/2c5a87ab54f448cfff167d95821065b529ac8952/odata2-lib/odata-core/src/main/java/org/apache/olingo/odata2/core/edm/EdmDateTime.java#L116

[rareddy]

so precision on date reflects the nanoseconds on DateTime.

So, if the "scale" on Datetime gets converted to "precision" on outbound, we need to set "precision" as "scale" on ingest, however I do not see similar behavior on OData V4, should be changed there too?

[shawkins]

however I do not see similar behavior on OData V4, should be changed there too?

Yes that appears to have the same issue.

[rareddy]

@shawkins Updated the code per your suggestions for the TIMESTAMP type.

[shawkins]

The only issue is that it's still setting the precision on a timestamp. The Teiid precision for a timestamp matches the jdbc definition - the length of the string definition. So you could leave it unset, or if the precision is 0, then set it to 19, otherwise 20+odata precision.

[rareddy]

@shawkins Updated the PR to left it unset for timestamp.

[shawkins]

LGTM