Add describe subcommand #37
Conversation
tekton-robot
added
size/L
|
/ok-to-test |
tekton-robot
removed
the
needs-ok-to-test
|
/retest |
There was a problem hiding this comment.
Thanks!! 👍 @pradeepitm12
Also, could we keep a line gap between printing each resource and make resource name in plural form like TASKS, RUNS?
e.g.
NAME : pipeline
RESOURCES
NAME TYPE
No resources
TASKS
NAME TASKREF RUNAFTER
No tasks
RUNS
NAME STARTED DURATION STATUS
pipeline-run-1 15 minutes ago 10 minutes Succeeded
|
/retest |
|
@vdemeester could you review it, please? |
|
/retest |
There was a problem hiding this comment.
I think we don't need to UPPERCASE everything I think 👼 (only the table column headers), like below
Name : voting-build-pipeline
Resources
NAME TYPE
samples-git git
voting-vote-image image
voting-worker-image image
voting-result-image image
Tasks
NAME TASKREF RUNAFTER
build-worker mvn-build []
build-worker-image buildah []
build-vote-image buildah []
build-result-image buildah []
Runs
No runs
Otherwise, few comments, but looks good 👍
|
/retest |
This adds a describe subcommand to pipeline subcommand,to describe given pipeline. eg - tkn pipeline describe pipelinename Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hrishin, piyush-garg, pradeepitm12, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This adds a describe subcommand to pipeline subcommand,to describe
given pipeline.
eg - tkn pipeline describe pipelinename
Signed-off-by: Pradeep Kumar pradkuma@redhat.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
Release Notes