Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web panelling for 'manually create a pipelinerun' #108

Closed
mnuttall opened this issue May 1, 2019 · 8 comments
Closed

Web panelling for 'manually create a pipelinerun' #108

mnuttall opened this issue May 1, 2019 · 8 comments
Assignees

Comments

@mnuttall
Copy link
Contributor

mnuttall commented May 1, 2019

We have a REST API that supports the manual creation of pipelineruns.

The parameters that a user must provide will be specific to the pipeline they're creating a run for - luckily they're all defined in the pipeline.

The UI will need to obtain and parse the desired pipeline before populating the fields that need user entry.

@ncskier
Copy link
Member

ncskier commented May 7, 2019

/assign

@ncskier
Copy link
Member

ncskier commented May 13, 2019

@mnuttall @AlanGreene
What is the overall "plan" is for namespace selection? I saw that there was recently a namespace dropdown added to the side menu. Should I use the selected namespace for my paneling, or should I have my own namespace dropdown?

Also, what is the flow for how the user should access this page to create a PipelineRun? (what link does the user click to get them to this page, and what page is this link on?) My paneling could probably be linked to from the main menu. Or, if the user is on a Pipeline's page, should I add a button to create a PipelineRun for that Pipeline?

@ncskier
Copy link
Member

ncskier commented May 14, 2019

Update: I just talked with Mark about the namespace selection, and we agreed to use the "global" namespace that was recently introduced.

@ncskier
Copy link
Member

ncskier commented May 16, 2019

Here are a couple of approaches to how the user should access the Create PipelineRun page.

Option 1: from the side menu

In this approach, there is always a button in the side menu that will bring the user to the Create PipelineRun page. Maybe we could make another category called Actions for this button and other future actions like creating Tekton resources.
createPipelineRun01

Option 2: button in the PipelineRun list

In this approach, the Pipeline option on the Create PipelineRun page would be pre-populated with the Pipeline ref. So, in this example it would be pre-populated with pipeline0
createPipelineRun02

Example barebones Create PipelineRun page:

Screen Shot 2019-05-16 at 11 50 15 AM

@mnuttall @AlanGreene which option do you think is best for navigating to the Create PipelineRun page? Is there another approach that you have in mind? Should I do both option 1 and 2?

@AlanGreene
Copy link
Member

Personally I'd prioritise option 2, and also consider adding it to the Pipeline list as described in #38

For option 1 I'm concerned the nav could get a bit busy with all the create options added (Pipeline, PipelineRun, Resource, Credential, etc.). We should definitely have something easily accessible that doesn't require navigating through multiple layers of the application, so let's try option 2 first and see if we feel we need more.

@ncskier
Copy link
Member

ncskier commented May 17, 2019

Ok, thanks for the feedback Alan. I'll put a button in the PipelineRun list.

@ncskier
Copy link
Member

ncskier commented Jul 3, 2019

PR #295 completes this issue
/close

@tekton-robot
Copy link
Contributor

@ncskier: Closing this issue.

In response to this:

PR #295 completes this issue
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants