Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for display details of PipelineRun which uses Pipeline from Tekton Bundle #2087

Closed
mdreizin opened this issue Jun 10, 2021 · 15 comments · Fixed by #2228
Closed
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mdreizin
Copy link

Describe the bug

Dashboard does not display any details of PipelineRun which uses Pipeline from Tekton Bundle:

---
apiVersion: tekton.dev/v1beta1
kind: PipelineRun
metadata:
  name: my-pipeline-1
spec:
  pipelineRef:
    name: my-pipeline
    bundle: grc.io/my-catalog/my-pipeline:0.1
  params: []

Expected behaviour

It would be nice to display details of such PipelineRun-s.

Steps to reproduce the bug

  1. Publish Pipeline as Tekton Bundle
  2. Create a simple PipelineRun which will use Pipeline from that bundle.

Environment details

  • Kubernetes Platform: GCP
  • Kubernetes or OpenShift version:
  • Install mode (if on OpenShift): -
  • Cloud-provider/provisioner: GKE
  • Versions:
    • Tekton Dashboard: 0.17.0
    • Tekton Pipelines: 0.24.1
    • Tekton Triggers: 0.14.1
  • Install namespaces:
    • Tekton Dashboard: tekton-pipelines
    • Tekton Pipelines: tekton-pipelines
    • Tekton Triggers: tekton-pipelines

Additional Info

A simple workaround is to publish a pipeline by kubectl to display missing details.

@mdreizin mdreizin added the kind/bug Categorizes issue or PR as related to a bug. label Jun 10, 2021
@AlanGreene
Copy link
Member

AlanGreene commented Jun 10, 2021

Thanks for opening the issue @mdreizin. This is definitely something we want to add (surprised we didn't already have an issue tracking it…). @afrittoli I thought you had opened an issue on this but maybe I imagined it.

There are a few ways we could approach this, including using more information from the PipelineRun status instead of relying on the Pipeline and Task definitions in some cases.

Note: for anyone looking for more information on the bundles functionality, see https://tekton.dev/docs/pipelines/pipelines/#tekton-bundles

@AlanGreene AlanGreene added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jun 10, 2021
@mdreizin
Copy link
Author

@AlanGreene Not at all! I am looking forward to arriving that feature.

@mdreizin
Copy link
Author

Do you have any updates? :)

@AlanGreene
Copy link
Member

No updates on this feature just yet. We're coming to the end of a major refactoring effort that touched almost every part of the application. Once that's complete we'll be reevaluating the open feature requests and this is one of the high priority items.

@mdreizin
Copy link
Author

Thank you very much for sharing updates.

@mdreizin
Copy link
Author

Also it would be nice to support Pipelines in Pipelines as well.

@AlanGreene
Copy link
Member

@mdreizin I agree, we're tracking Custom Task support in #1970

@mdreizin
Copy link
Author

@AlanGreene I will track that related issue 👀. Thank you for sharing!

@AlanGreene
Copy link
Member

As discussed today, @briangleeson and Jerh will take a look at this over the next 2 weeks to determine the current state of Dashboard support for Tekton Bundles, and options for improving this based on information already available in the TaskRun/PipelineRun.

We need to test a number of scenarios where TaskRun / PipelineRun references bundles, including:

  • no definitions applied on-cluster (i.e. all coming from bundles)
  • definitions applied on-cluster match those from the bundles
  • definitions applied on-cluster differ from those in referenced bundles

In all cases we should record what information is available in the TaskRun / PipelineRun that might allow us to reconstruct the required details, e.g. the taskSpec or pipelineSpec in the status field. Is this always available?

If there's not sufficient information available, what are the options to obtain it?

Once we have an accurate picture of the current state we can plan the required changes to add support.

briangleeson added a commit to briangleeson/dashboard that referenced this issue Nov 1, 2021
Add support for PipelineRun and TaskRun from Tekton Bundles. PipelineRun and TaskRun pages now display the usual pipeline or task details.
tekton-robot pushed a commit that referenced this issue Nov 2, 2021
Add support for PipelineRun and TaskRun from Tekton Bundles. PipelineRun and TaskRun pages now display the usual pipeline or task details.
@AlanGreene
Copy link
Member

@mdreizin fyi, this is available in the latest nightly build and will be included in the upcoming Dashboard v0.22 release in the next week or so.

@mdreizin
Copy link
Author

mdreizin commented Nov 3, 2021

@AlanGreene Thank you for sharing great news! we will try to use it and I let you know.

@mdreizin
Copy link
Author

mdreizin commented Nov 3, 2021

@AlanGreene I am sorry for asking. Could you please share a link where I can find nightly builds?

@mdreizin
Copy link
Author

@AlanGreene We have just installed released version and it works well without any issues. Thank you very much for implementing it!

@AlanGreene
Copy link
Member

Glad to hear it's working well for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants