Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DEVELOPMENT.md to suggest Node.js 10.x and npm ci over npm install #317

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

jessm12
Copy link
Member

@jessm12 jessm12 commented Jul 8, 2019

Changes

Update DEVELOPMENT.md to suggest Node.js 10.x and npm ci over npm install

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 8, 2019
@jessm12 jessm12 changed the title Update DEVELOPMENT.md to suggest Node.js 10.x and npm ci over npm ins… Update DEVELOPMENT.md to suggest Node.js 10.x and npm ci over npm install Jul 8, 2019
@jessm12
Copy link
Member Author

jessm12 commented Jul 8, 2019

/retest

@jessm12
Copy link
Member Author

jessm12 commented Jul 8, 2019

/test tekton-dashboard-unit-tests

DEVELOPMENT.md Outdated Show resolved Hide resolved
Copy link
Member

@AlanGreene AlanGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2019
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlanGreene, jessm12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2019
@tekton-robot tekton-robot merged commit b4d4ab9 into tektoncd:master Jul 8, 2019
@jessm12 jessm12 deleted the npmci branch July 8, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants