Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Secrets modal doesnt auto use namespace on left #975

Closed
CarolynMabbott opened this issue Jan 29, 2020 · 6 comments
Closed

Create Secrets modal doesnt auto use namespace on left #975

CarolynMabbott opened this issue Jan 29, 2020 · 6 comments

Comments

@CarolynMabbott
Copy link
Member

CarolynMabbott commented Jan 29, 2020

Expected behavior

Create Secrets modal uses namespace on left

Actual behavior

Have to select a namespace myself

Steps to reproduce the problem

  1. Change namespace on left
  2. Open secrets modal

Environment

  • Kubernetes Platform:

Docker desktop

  • Tekton Pipelines version:
  • Tekton Triggers version:
  • Tekton Dashboard version:

master

Additional Info

@AlanGreene
Copy link
Member

I think this was intentional, @carlos-logro maybe you can remember? If we want to change this behaviour we should do it as part of #727

@carlos-logro
Copy link
Contributor

Yeah I don't remember discussing having to choose it from the left side. But sure, ill add it as part of that issue.

@AlanGreene
Copy link
Member

hrmm I can't find the discussion now, but I'm pretty sure we decided that the namespace dropdown in the create secret dialog should be separate from the one in the nav.

It might make sense to have the namespace dropdown in the create UI default to the selected namespace from the nav, but I think it's still useful to allow the user to then select a different namespace without affecting other pages.

The updated designs only have the global namespaces dropdown on list views, so there would be no conflict in this case as the only namespace dropdown displayed when creating a secret would be the one in the create form.

@CarolynMabbott CarolynMabbott changed the title Secrets modal doesnt auto use namespace on left Create Secrets modal doesnt auto use namespace on left Feb 7, 2020
@CarolynMabbott
Copy link
Member Author

@AlanGreene I meant for the create secret modal
Should auto use the namespace on the left in the create modal but the user can change the namespace on either
It's just annoying on openshift where you have the namespace on the left selected as tekton-pipelines and then when creating a secret in the modal you have to scroll all the way down to the namespace in the create modal

@AlanGreene
Copy link
Member

AlanGreene commented Feb 7, 2020

Yes I agree, that's what I meant by:

It might make sense to have the namespace dropdown in the create UI default to the selected namespace from the nav

It's also worth bearing in mind that the modals will be going away, replaced with a full page experience.

@AlanGreene
Copy link
Member

Closing in favour of #1304 which is tracking a single consistent approach to resolving these namespace-related issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants