Fix client mode #2112
Merged
Fix client mode #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the error handling code used to detect when the Dashboard is running in client mode (via `kubectl proxy`). Remove the unwanted `data` field so we can correctly process the response and provide the expected default install properties.
tekton-robot
added
the
size/XS
|
/test pull-tekton-dashboard-build-tests |
|
/test tekton-dashboard-unit-tests |
|
/test pull-tekton-dashboard-integration-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson, ziheng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#1388
Fix the error handling code used to detect when the Dashboard
is running in client mode (via
kubectl proxy). Remove theunwanted
datafield so we can correctly process the responseand provide the expected default install properties.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.