Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status information to Runs and Run pages #2416

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

AlanGreene
Copy link
Member

@AlanGreene AlanGreene commented Aug 18, 2022

Changes

Related to #1970

Update the list page for Run resources to match the design for the
PipelineRuns and TaskRuns pages, including PipelineRun/Trigger info,
status, time, etc.

Add status info to the additional metadata section on the details
page, using the same content displayed in the status tooltip on the
Runs list page.

Ensure Runs are sorted by creation time so their display is consistent
with TaskRuns, PipelineRuns, etc., and newer runs appear at the top.

Since we do not know all of the possible status reasons for custom tasks,
we assign a default status icon to keep text alignment while the Run is
in a non-terminal state.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

See the contribution guide
for more details.

Update the list page for Run resources to match the design for the
PipelineRuns and TaskRuns pages, including PipelineRun/Trigger info,
status, time, etc.

Add status info to the additional metadata section on the details
page, using the same content displayed in the status tooltip on the
Runs list page.

Ensure Runs are sorted by creation time so their display is consistent
with TaskRuns, PipelineRuns, etc., and newer runs appear at the top.

Since we do not know all of the possible status reasons for custom tasks,
we assign a default status icon to keep text alignment while the Run is
in a non-terminal state.
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 18, 2022
@AlanGreene AlanGreene requested review from briangleeson and removed request for skaegi August 18, 2022 16:03
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2022
@tekton-robot tekton-robot merged commit d6629e6 into tektoncd:main Aug 18, 2022
@AlanGreene AlanGreene deleted the custom_tasks_design branch August 18, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants