Update to React Router 6 #3423
Merged
Update to React Router 6 #3423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow the remaining steps in the migration guide to replace the compat layer with actual use of React Router 6 directly. This includes: - move `Route` children into the `element` prop - refactor use of the `Link`'s `component` prop to the new approach - update tests to avoid relying on `history` - and more While this does update us to React Router 6 there is still more to be done to take advantage of the new features, such as the `handle` prop on `Route`s to avoid the need for our custom `NamespacedRoute` component etc. This will be tackled in the near future and will dramatically simplify the code, allowing for a more uniform approach to handling Kube resources without the current overhead of custom containers per kind etc.
tekton-robot
added
kind/misc
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#2452
Follow the remaining steps in the migration guide to replace the compat layer with actual use of React Router 6 directly. This includes:
Routechildren into theelementpropLink'scomponentprop to the new approachhistoryWhile this does update us to React Router 6 there is still more to be done to take advantage of the new features, such as the
handleprop onRoutes to avoid the need for our customNamespacedRoutecomponent etc. This will be tackled in the near future and will dramatically simplify the code, allowing for a more uniform approach to handling Kube resources without the current overhead of custom containers per kind etc./kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes