Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds v1 support to APIs #163

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Adds v1 support to APIs #163

merged 1 commit into from
Jan 13, 2021

Conversation

sm43
Copy link
Member

@sm43 sm43 commented Jan 11, 2021

This adds /v1 support to existing APIs. This adds additional route
with existing for all user facing APIs. Preview route will be
deprecated in next release after first non-preview.

Signed-off-by: Shivam Mukhade smukhade@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 11, 2021
@sm43
Copy link
Member Author

sm43 commented Jan 11, 2021

/retest

1 similar comment
@sm43
Copy link
Member Author

sm43 commented Jan 11, 2021

/retest

This adds /v1 support to existing APIs. This adds additional route
with existing for all user facing APIs. Preview route will be
deprecated in next release after first non-preview.

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2021
@piyush-garg
Copy link
Contributor

/lgtm

@PuneetPunamiya
Copy link
Member

/lgtm
/approve
/meow

@tekton-robot
Copy link

@PuneetPunamiya: cat image

In response to this:

/lgtm
/approve
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PuneetPunamiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2021
@tekton-robot tekton-robot merged commit f645eea into tektoncd:master Jan 13, 2021
@sm43 sm43 deleted the v1-support branch April 15, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants