-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEP-0079] Add "type" flag to CLI #692
Conversation
87472ce
to
e91df27
Compare
The Hub CLI is used as a sub command "tkn hub" in https://github.com/tektoncd/cli. Prior to this change, the Hub CLI only supports to fetch catalog resources from Tekton Hub. This commit introduces a new flag "type" specifying the type of Hub to pull the resources from. The value can be set to either "artifact" or "tekton". When setting to "artifact", the CLI fetches resources from Artifact Hub; when setting to "tekton", the CLI fetches resources from the Tekton Hub. The implementation for fetching resouces from Artifact Hub will come in the following PRs.
e91df27
to
3531e93
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pratap0007, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pratap0007 @vdemeester Can one of you please switch from approve to /lgtm to merge this PR? 😁 |
/lgtm |
Changes
Part of #691. The Hub CLI is used as a sub command
tkn hub
in https://github.com/tektoncd/cli. Prior to this change, the Hub CLI only supports to fetch catalog resources from Tekton Hub. This commit introduces a new flagtype
specifying the type of Hub to pull the resources from. The value can be set to eitherartifact
ortekton
. When setting toartifact
, the CLI fetches resources from the Artifact Hub; when setting totekton
, the CLI fetches resources from the Tekton Hub.The implementation for fetching resources from Artifact Hub will come in the following PRs.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make api-check
make ui-check
See the contribution guide for more details.