Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEP-0079] Add "type" flag to CLI #692

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

QuanZhang-William
Copy link
Member

@QuanZhang-William QuanZhang-William commented Oct 14, 2022

Changes

Part of #691. The Hub CLI is used as a sub command tkn hub in https://github.com/tektoncd/cli. Prior to this change, the Hub CLI only supports to fetch catalog resources from Tekton Hub. This commit introduces a new flag typespecifying the type of Hub to pull the resources from. The value can be set to either artifact or tekton. When setting to artifact, the CLI fetches resources from the Artifact Hub; when setting to tekton, the CLI fetches resources from the Tekton Hub.

The implementation for fetching resources from Artifact Hub will come in the following PRs.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run API Unit Tests, Lint Checks, API Design, Golden Files with make api-check
  • Run UI Unit Tests, Lint Checks with make ui-check
  • Commit messages follow commit message best practices

See the contribution guide for more details.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 14, 2022
@QuanZhang-William QuanZhang-William force-pushed the add-type-flag branch 3 times, most recently from 87472ce to e91df27 Compare October 17, 2022 19:23
The Hub CLI is used as a sub command "tkn hub" in https://github.com/tektoncd/cli. Prior to this change, the Hub CLI only supports to fetch catalog resources from Tekton Hub. This commit introduces a new flag "type" specifying the type of Hub to pull the resources from. The value can be set to either "artifact" or "tekton". When setting to "artifact", the CLI fetches resources from Artifact Hub; when setting to "tekton", the CLI fetches resources from the Tekton Hub.

The implementation for fetching resouces from Artifact Hub will come in the following PRs.
@pratap0007
Copy link
Contributor

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2022
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pratap0007, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pratap0007,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@QuanZhang-William
Copy link
Member Author

@pratap0007 @vdemeester Can one of you please switch from approve to /lgtm to merge this PR? 😁

@PuneetPunamiya
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2022
@tekton-robot tekton-robot merged commit 455111d into tektoncd:main Oct 26, 2022
@QuanZhang-William QuanZhang-William changed the title Add "type" flag to CLI [TEP-0079] Add "type" flag to CLI Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants