[TEP-0079] Add "type" flag to CLI #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/L
QuanZhang-William
force-pushed
the
add-type-flag
branch
3 times, most recently
from
87472ce
to
e91df27
Compare
The Hub CLI is used as a sub command "tkn hub" in https://github.com/tektoncd/cli. Prior to this change, the Hub CLI only supports to fetch catalog resources from Tekton Hub. This commit introduces a new flag "type" specifying the type of Hub to pull the resources from. The value can be set to either "artifact" or "tekton". When setting to "artifact", the CLI fetches resources from Artifact Hub; when setting to "tekton", the CLI fetches resources from the Tekton Hub. The implementation for fetching resouces from Artifact Hub will come in the following PRs.
QuanZhang-William
force-pushed
the
add-type-flag
branch
from
e91df27
to
3531e93
Compare
|
/approve |
tekton-robot
added
the
approved
vdemeester
approved these changes
Oct 21, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pratap0007, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pratap0007 @vdemeester Can one of you please switch from approve to /lgtm to merge this PR? 😁 |
|
/lgtm |
4 tasks
QuanZhang-William
changed the title
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Part of #691. The Hub CLI is used as a sub command
tkn hubin https://github.com/tektoncd/cli. Prior to this change, the Hub CLI only supports to fetch catalog resources from Tekton Hub. This commit introduces a new flagtypespecifying the type of Hub to pull the resources from. The value can be set to eitherartifactortekton. When setting toartifact, the CLI fetches resources from the Artifact Hub; when setting totekton, the CLI fetches resources from the Tekton Hub.The implementation for fetching resources from Artifact Hub will come in the following PRs.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make api-checkmake ui-checkSee the contribution guide for more details.