-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Helm chart for installing Tekton Operator #627
Conversation
|
Hi @jacksgt. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cool finally we have a helm chart! Thanks @jacksgt! |
Hi @jacksgt |
yep documentation would be useful to understand and test it out 👍🏽 🙂 |
Hi, thanks!
Sure, done!
I have added a README. Let me know if the instructions are clear for you. |
another reason it is failing on openshift is #643 |
Thanks for taking a look and giving the chart a try Shivam!
I have also change the default target namespace based on the flavor: unless explicitly overridden, it now uses |
|
Those settings are directly injected as environment variables into the Tekton operator: https://github.com/tektoncd/operator/pull/627/files#diff-2c6c478bf17d4896de57d0def131d88f926a02e3a0159954b1e1457a19b78bebR54 |
@jacksgt 💯 👍 for this pr. please excuse the delay. we got a bit busy trying to handle the new additions like TektonHub and TektonChains in operator. 🕺 |
@jacksgt sorry for the delay in reviews. |
Hi @sm43 , sorry for the late reply, I finally got around to addressing your feedback.
There was a minor issue in the YAML names. I fixed it and verified that it deploys on k8s and openshift.
Yes, done. Also rebased on latest
Please give it another go :-)
Yes, I can address this in a follow-up MR. I guess you have some kind of script for creating a release, we just need to add a few commands there (for updating the appVersion and chart version). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest as #769 has merged, ci should pass |
/retest |
Hello folks, the tests passed, is there anything else left to do for this PR? :-) |
Thanks for taking the time to check again!
Thanks for the hint! I synced the CRDs with the YAMLs from release 0.57
This seems to be an inconsistency with the 0.56 release. I'll make sure to submit a follow-up MR that will automatically sync the CRDs for each new release and bump the chart version. |
for 0.57.0 you will need to include 9819f1d this change too ! then we are good to merge 🙃 |
Signed-off-by: Jack Henschel <jackdev@mailbox.org>
Ohhh thanks for the hint, very kind of you! I updated the chart accordingly. |
/test pull-tekton-operator-go-coverage |
/retest |
@jacksgt: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hello Tekton operators!
Changes
As discussed in #543 , the tekton-operator could really use a Helm chart for installation.
Helm is widely used in the Kubernetes ecosystem and allows for easy configuration of the installed components.
At the same time it gives much more flexibility when compared to installing from OperatorHub.
We are using an internal Helm chart for deploying the Operator, so I thought I'd share the chart here.
I have not added extensive documentation for it yet, but will do before merging this PR.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes