Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description field to Resources in Tasks #1389

Closed
bobcatfish opened this issue Oct 7, 2019 · 6 comments
Closed

Add description field to Resources in Tasks #1389

bobcatfish opened this issue Oct 7, 2019 · 6 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@bobcatfish
Copy link
Collaborator

Expected Behavior

It should be easy to tell from looking at a Task what the intended usage is of any PipelineResources the Task requires.

Actual Behavior

We have description fields for params but not for input or output PipelineResources, for exmaple the kaniko Task from the catalog:

  inputs:
    params:
    - name: DOCKERFILE
      description: Path to the Dockerfile to build.
      default: ./Dockerfile
    - name: CONTEXT
      description: The build context used by Kaniko.
      default: ./
    resources:
    - name: source
      type: git
  outputs:
    resources:
    - name: image
      type: image

Additional Info

Related issue about creating a tool to display documentation (which would need fields like this): tektoncd/catalog#7

@bobcatfish bobcatfish added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 7, 2019
@bobcatfish bobcatfish added this to the Pipelines 0.9 🐱 milestone Oct 7, 2019
@toshi0607
Copy link
Contributor

Is adding Description to Inputs and Outputs type in v1alpha/task_types.go right way to solve this issue? If it's not wrong approach, may I challenge this?

@skaegi
Copy link
Contributor

skaegi commented Oct 8, 2019

I'm hoping we could add something like ParamSpec Description to
ResourceDeclaration

@3sky
Copy link

3sky commented Oct 18, 2019

OK, let's begin /assign it to me.

@toshi0607
Copy link
Contributor

/assign @toshi0607

@vdemeester
Copy link
Member

#1875 got merged so I think we can safely close
/close

@tekton-robot
Copy link
Collaborator

@vdemeester: Closing this issue.

In response to this:

#1875 got merged so I think we can safely close
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

6 participants