Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0127: Larger Results via Sidecar Logs [Feedback Requested] #6133

Closed
jerop opened this issue Feb 8, 2023 · 5 comments · Fixed by #8043
Closed

TEP-0127: Larger Results via Sidecar Logs [Feedback Requested] #6133

jerop opened this issue Feb 8, 2023 · 5 comments · Fixed by #8043
Labels
Epic Issues that should be considered as Epics (aka multiple sub-tasks, …) lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone
Pipeline v0.61

Comments

@jerop
Copy link
Member

jerop commented Feb 8, 2023

In TEP-0127, we proposed Larger Results via Sidecar Logs. This feature was added in release v0.43 as an alpha feature that's guarded behind the results-from feature flag. For further details, see the documentation.

This is an issue to gather feedback from users who have tried out the the feature, so that we can figure out a way forward.
@jerop jerop added the Epic Issues that should be considered as Epics (aka multiple sub-tasks, …) label Feb 8, 2023
@jerop jerop changed the title TEP-0127: Larger Results via Sidecar Logs [Feedback] TEP-0127: Larger Results via Sidecar Logs [Feedback Requested] May 1, 2023
@jerop jerop added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label May 1, 2023
@pritidesai
Copy link
Member

pritidesai commented Aug 1, 2023 •
edited by chitrangpatel
Loading

The larger results via sidecar logs is a huge improvement to address 4K termination message size limitation. I am evaluating using this feature in our service. This feature does not help accomplish artifacts use case but it is a step forward while working with a reasonable size of task results.

This is a live list of to-dos for making sure this feature can be promoted to beta:

  • Fix formatting issues in docs and add a complete set of instructions on how to enable larger results using sidecar logs. The additional-configs has the set of instructions, either we move them under docs/tasks.md or provide a reference to additional-configs from docs/tasks.md.
  • Add multiple tasks producing multiple task results in an example pipeline.
  • Add an example pipeline which has a task producing large results + onError is set to continue. This test is necessary to check the sidecar sidecar-tekton-log-results supports non-zero exit code of any container.
  • Add e2e test to validate the task results are produced with a failed task.
  • Add an example pipeline to produce task results of all supported types including array and object.

@jerop
Copy link
Member Author

jerop commented Aug 7, 2023

@pritidesai thank you for the feedback, will prioritize making the improvements that you've suggested

@pritidesai pritidesai mentioned this issue Sep 13, 2023
Merged
7 tasks
@pritidesai pritidesai added this to the Pipelines v0.53 milestone Sep 14, 2023
@pritidesai pritidesai mentioned this issue Sep 22, 2023
Merged
7 tasks
@dibyom
Copy link
Member

dibyom commented Oct 3, 2023

@JeromeJu @pritidesai mentioned that larger results tests are gated by both the alpha flag as well as a dedicated feature flag. Can we use just one of them or is this intentional?

@jerop
Copy link
Member Author

jerop commented Oct 3, 2023 •
edited
Loading

@JeromeJu @pritidesai mentioned that larger results tests are gated by both the alpha flag as well as a dedicated feature flag. Can we use just one of them or is this intentional?

It is no longer gated behind the alpha feature flag - #6939

@jerop jerop mentioned this issue Oct 27, 2023
Closed
@jerop jerop modified the milestones: Pipelines v0.54, Pipelines v0.55 Nov 9, 2023
@l-qing l-qing mentioned this issue Jun 6, 2024
Merged
8 tasks
chitrangpatel added a commit to chitrangpatel/pipeline that referenced this issue Jun 10, 2024
@chitrangpatel
Tests before promoting LargerResults via Sidecarlogs to Beta
30cbfc9 
tektoncd#6133 identified missing
example/e2e tests to complete before promoting Larger Results via
Sidecar Logs to Beta. This PR updates the e2e tests with:
* Multiple Tasks with Multiple Results in a  Pipeline
* A Step producing Result fails with OnError continue
* A Failed Task in the Pipeline
@chitrangpatel chitrangpatel mentioned this issue Jun 10, 2024
Merged
8 tasks
@chitrangpatel
Copy link
Contributor

#8041 adds the tests

chitrangpatel added a commit to chitrangpatel/pipeline that referenced this issue Jun 10, 2024
@chitrangpatel
Promote Larger Results via Sidecar Logs to Beta
06deb0f 
This PR promotes Larger Results via Sidecar Logs to Beta.
All items as per Issue tektoncd#6133
have been completed. It was released in `v0.43` so has been in an alpha
state for a while now.
@chitrangpatel chitrangpatel mentioned this issue Jun 10, 2024
Merged
8 tasks
chitrangpatel added a commit to chitrangpatel/pipeline that referenced this issue Jun 11, 2024
@chitrangpatel
Promote Larger Results via Sidecar Logs to Beta
0153190 
This PR promotes Larger Results via Sidecar Logs to Beta.
All items as per Issue tektoncd#6133
have been completed. It was released in `v0.43` so has been in an alpha
state for a while now.
chitrangpatel added a commit to chitrangpatel/pipeline that referenced this issue Jun 11, 2024
@chitrangpatel
Promote Larger Results via Sidecar Logs to Beta
ded1081 
This PR promotes Larger Results via Sidecar Logs to Beta.
All items as per Issue tektoncd#6133
have been completed. It was released in `v0.43` so has been in an alpha
state for a while now.
tekton-robot pushed a commit that referenced this issue Jun 12, 2024
@chitrangpatel @tekton-robot
Tests before promoting LargerResults via Sidecarlogs to Beta
351cb9a 
#6133 identified missing
example/e2e tests to complete before promoting Larger Results via
Sidecar Logs to Beta. This PR updates the e2e tests with:
* Multiple Tasks with Multiple Results in a  Pipeline
* A Step producing Result fails with OnError continue
* A Failed Task in the Pipeline
chitrangpatel added a commit to chitrangpatel/pipeline that referenced this issue Jun 12, 2024
@chitrangpatel
Promote Larger Results via Sidecar Logs to Beta
7f90c25 
This PR promotes Larger Results via Sidecar Logs to Beta.
All items as per Issue tektoncd#6133
have been completed. It was released in `v0.43` so has been in an alpha
state for a while now.
chitrangpatel added a commit to chitrangpatel/pipeline that referenced this issue Jun 13, 2024
@chitrangpatel
Promote Larger Results via Sidecar Logs to Beta
2474aa6 
This PR promotes Larger Results via Sidecar Logs to Beta.
All items as per Issue tektoncd#6133
have been completed. It was released in `v0.43` so has been in an alpha
state for a while now.
tekton-robot pushed a commit that referenced this issue Jun 17, 2024
@chitrangpatel @tekton-robot
Promote Larger Results via Sidecar Logs to Beta
b1ee06c 
This PR promotes Larger Results via Sidecar Logs to Beta.
All items as per Issue #6133
have been completed. It was released in `v0.43` so has been in an alpha
state for a while now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Epic Issues that should be considered as Epics (aka multiple sub-tasks, …) lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
Pipeline v0.61
Development

Successfully merging a pull request may close this issue.

Promote Larger Results via Sidecar Logs to Beta chitrangpatel/pipeline
7 participants
@vdemeester @pritidesai @afrittoli @dibyom @chitrangpatel @jerop @JeromeJu