[v0.44.x] Conversion webhook is misbehaving on kubectl patch

[vdemeester]

Expected Behavior

When doing a kubectl patch to add an annotation on a v1 type (like PipelineRun), I expect it to keep the existing annotations.

Actual Behavior

When doing a kubectl patch to add an annotation on a v1 type (like PipelineRun), the existing annotations are gone, which is a big problem when using embedded-status: both, as tekton.dev/v1beta1Taskruns being gone, we are loosing some data.

Steps to Reproduce the Problem

1. Deploy v0.44.x on a cluster
2. Edit the feature-flags configmap to set embedded-status: both
3. Execute a PipelineRun, kubectl create -f ./examples/v1beta1/pipelineruns/pipelinerun.yaml
4. Do k get v1beta1.pipelinerun.tekton.dev/demo-pipeline-run-1 -o yaml once finished, and look at the status.taskRuns being populated
5. Patch the PipelineRun using kubectl patch pr demo-pipeline-run-1 --type='json' -p='[{"op": "add", "path": "/metadata/annotations/foo", "value":"bar"}]'
6. Get the v1beta1 PipelineRun using k get v1beta1.pipelinerun.tekton.dev/demo-pipeline-run-1 -o yaml and see that we do not have the status.taskRuns anymore

Additional Info

• Tekton Pipeline version:

  Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'

v0.44.x

[vdemeester]

/assign

[vdemeester]

Quick note : the same behavior applies when trying to patch labels or anything really (for example, the timeout field) — using kubectl path or kubectl edit.

[vdemeester]

Alright, I did figure something out it seems. I did add a log to print what "config" it sees for embedded-status. And it turns out, even if the value in the configmap is both, the one that the webhook prints is minimal.