-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky TestGetStatuses by sorting slices before comparing them #1072
Conversation
/test pull-tekton-pipeline-integration-tests |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you :)
I've hit the same issue on the CloudEventPipelineResource and had the same solution with sorting.
/retest |
Awesome find @dibyom !!! Thank you 😻 /lgtm |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, bobcatfish, dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Fix flaky TestGetStatuses by sorting slices before comparing them.
This should also help fix some of the flakiness with the integration tests because one of the YAML tasks clones and runs unit tests for the pipeline repo in a taskrun e.g. https://tekton-releases.appspot.com/build/tekton-prow/pr-logs/pull/tektoncd_pipeline/1071/pull-tekton-pipeline-integration-tests/1149698811799539712/
Fixes #1049
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them: