-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GcsFetcher and GcsUploader images to release task and pipeline #1196
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
These two images were added in tektoncd#1159 and the release task and pipeline have to be updated for a release to be successful. Also, fixes a typo in the pull request resource image name. Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
/test pull-tekton-pipeline-integration-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/meow space
value: github.com/tektoncd/pipeline | ||
value: gcr.io/tekton-releases # REPLACE with your own registry | ||
- name: package | ||
value: github.com/tektoncd/pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah the YAML indentation is wrong : https://github.com/tektoncd/pipeline/blob/master/tekton/release-pipeline-run.yaml#L14
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
These two images were added in #1159 and the release task and pipeline
have to be updated for a release to be successful. Also, fixes a typo in
the pull request resource image name.
Submitter Checklist