Remove cmd/gsutil image #1504
Remove cmd/gsutil image #1504
Conversation
googlebot
added
the
cla: yes
tekton-robot
added
the
size/XXL
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
There was a problem hiding this comment.
@imjasonh what are those .go-e files ? I feel they shouldn't be there 😛
Based on tektoncd#1503 This image wrapped any image with `gsutil` in the path (typically, `google/cloud-sdk`), and invoked it with our own custom Go wrapper. That's unnecessary, since `gsutil` can be invoked directly as necessary, using any image where `gsutil` is in the PATH (`google/cloud-sdk` is the default). This change should be entirely transparent to end users. Operators can override the image being used if they so desire, to point to any image that contains `gsutil`.
|
The following is the coverage report on pkg/.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-pipeline-integration-tests |
1 similar comment
|
/test pull-tekton-pipeline-integration-tests |
|
/test pull-tekton-pipeline-integration-tests ❄️ |
|
/lgtm |
|
It sounds like gcloud expects users to call We shouldn't introduce an image to run this for users, I think. Instead we should document this and make sure users know that gcloud expects this of them. |
|
Sounds good to me. We... probably need to consider this a breaking change in 0.9 tho right? I'll update the release notes. |
|
Yeah. If we guarantee this behavior going forward we should add a test. |
Based on #1503
This image wrapped any image with
gsutilin the path (typically,google/cloud-sdk), and invoked it with our own custom Go wrapper.That's unnecessary, since
gsutilcan be invoked directly as necessary,using any image where
gsutilis in the PATH (google/cloud-sdkis thedefault).
This change should be entirely transparent to end users.
Operators can override the image being used if they so desire, to point
to any image that contains
gsutil.Historical note:
cmd/gsutilwas added in #321, ostensibly to fix #124, though the specific rationale for the wrapper script might be lost to time. 🕥Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes