-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cmd/bash image #1503
Remove cmd/bash image #1503
Conversation
1b31f9d
to
d2284ea
Compare
/lgtm |
4e6ed1d
to
af19e0c
Compare
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
Based on tektoncd#1503 This image wrapped any image with `gsutil` in the path (typically, `google/cloud-sdk`), and invoked it with our own custom Go wrapper. That's unnecessary, since `gsutil` can be invoked directly as necessary, using any image where `gsutil` is in the PATH (`google/cloud-sdk` is the default). This change should be entirely transparent to end users. Operators can override the image being used if they so desire, to point to any image that contains `gsutil`.
Based on tektoncd#1503 This image wrapped any image with `gsutil` in the path (typically, `google/cloud-sdk`), and invoked it with our own custom Go wrapper. That's unnecessary, since `gsutil` can be invoked directly as necessary, using any image where `gsutil` is in the PATH (`google/cloud-sdk` is the default). This change should be entirely transparent to end users. Operators can override the image being used if they so desire, to point to any image that contains `gsutil`.
This image was previously responsible for invoking some specified bash commands, typically cp and mkdir, but occasionally more exotic things like setting up executable files for step scripts. Ultimately this image existed merely to pass args to "sh -c" (not even bash!), which can be done directly. This change should be entirely transparent to end users. Operators can override the image being used if they so desire, to point to any image that contains `sh` (and `cp`, `mkdir`, `cat`, the usual suspects).
The following is the coverage report on pkg/.
|
You probably have to update the release task since this removes an image from our release process. (See the checklist of stuff that's easy to miss) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @afrittoli (we may need to update something in plumbing
for the time being ?
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Based on tektoncd#1503 This image wrapped any image with `gsutil` in the path (typically, `google/cloud-sdk`), and invoked it with our own custom Go wrapper. That's unnecessary, since `gsutil` can be invoked directly as necessary, using any image where `gsutil` is in the PATH (`google/cloud-sdk` is the default). This change should be entirely transparent to end users. Operators can override the image being used if they so desire, to point to any image that contains `gsutil`.
Based on tektoncd#1503 This image wrapped any image with `gsutil` in the path (typically, `google/cloud-sdk`), and invoked it with our own custom Go wrapper. That's unnecessary, since `gsutil` can be invoked directly as necessary, using any image where `gsutil` is in the PATH (`google/cloud-sdk` is the default). This change should be entirely transparent to end users. Operators can override the image being used if they so desire, to point to any image that contains `gsutil`.
See tektoncd/pipeline#1503. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Based on #1503 This image wrapped any image with `gsutil` in the path (typically, `google/cloud-sdk`), and invoked it with our own custom Go wrapper. That's unnecessary, since `gsutil` can be invoked directly as necessary, using any image where `gsutil` is in the PATH (`google/cloud-sdk` is the default). This change should be entirely transparent to end users. Operators can override the image being used if they so desire, to point to any image that contains `gsutil`.
See tektoncd/pipeline#1503. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
See tektoncd/pipeline#1503. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
This image was previously responsible for invoking some specified bash
commands, typically cp and mkdir, but occasionally more exotic things
like setting up executable files for step scripts.
Ultimately this image existed merely to pass args to "sh -c" (not even
bash!), which can be done directly.
This change should be entirely transparent to end users.
Operators can override the image being used if they so desire, to point
to any image that contains
sh
(andcp
,mkdir
,cat
, the usualsuspects).
Fixes #1446 with extreme prejudice
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes