Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix re-applying v1beta1 TaskRun failing 🚢 #2285

Merged
merged 1 commit into from
Mar 25, 2020

Commits on Mar 25, 2020

  1. Fix re-applying v1beta1 TaskRun failing 🚢

    Re-apply a v1beta1 resource would failed because of `inputs` (or
    `outputs`) not a valid field. This is mainly because we are using
    `v1alpha1` as stored version and thus getting the struct as v1alpha1
    internally.
    
    This fixes this issue by marking `TaskRun.Spec.Inputs` and
    `TaskRun.Spec.Outputs` as pointers. It doesn't change the API, but
    fixes the problem as a `nil` pointer will not be unmarshall where the
    struct was.
    
    Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
    vdemeester committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    2f8ad6b View commit details
    Browse the repository at this point in the history