-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Step and Sidecar types #3077
Separate Step and Sidecar types #3077
Conversation
Hi @Peaorl. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fyi we usually don't add code editor exclude files in gitignore but usually to your global ignore/exclude file, see this article for more info : /ok-to-test |
/retest |
I think I understand the reason why but in this case we already have emacs, vscode and jetbrains ignore rules in place. Should we remove those? |
@@ -125,8 +125,15 @@ type Step struct { | |||
Script string `json:"script,omitempty"` | |||
} | |||
|
|||
// A sidecar has the same data structure as a Step, consisting of a Container, and optional Script. | |||
type Sidecar = Step | |||
// Sidecar has nearly the same data structure as Step, consisting of a Container and an optional Script, but does not have the ability to timeout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit: suggest matching comment style with others in the file and wrapping the lines around 80-100 characters.
similarly for other comments in this pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in new commit!
/test pull-tekton-pipeline-integration-tests (Retrying because there was a general problem fetching docker images) |
Could you squash the commits into one? Ah, you'll also need to include the following at the bottom of your PR description:
/kind cleanup |
41a78d5
to
defef46
Compare
defef46
to
41a78d5
Compare
41a78d5
to
8fd42b1
Compare
Originally the Sidecar type is an alias of the Step type. Both tektoncd#3013 and tektoncd#1690 will require the two types to divert from each other. This commit separates the two types and updates code to accomodate convertListOfSteps() which originally depended on theses types to be the same. Partially based on: https://github.com/tektoncd/pipeline/pull/3013/files
8fd42b1
to
f0954c7
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/test pull-tekton-pipeline-integration-tests |
Changes
This PR separates the Step and Sidecar types from each other (i.e. they are not simply aliases anymore).
This change is needed for #1690 and #3013.
Currently only one function relies on these two types to be aliases.
These changes are partially based on https://github.com/tektoncd/pipeline/pull/3013/files.
Additionally, .swp is added to the .gitignore file.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes