Clean up test cases in pipelinerun_test.go #3134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
the
size/L
vdemeester
added
kind/misc
pritidesai
reviewed
Aug 25, 2020
pritidesai
approved these changes
Aug 25, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
imjasonh
force-pushed
the
pipelinerun-test
branch
from
35ec1d6
to
19e462c
Compare
|
/lgtm |
vdemeester
added
kind/misc
imjasonh
force-pushed
the
pipelinerun-test
branch
from
19e462c
to
ab6aff7
Compare
|
/test pull-tekton-pipeline-integration-tests |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup
Rather than creating a bunch of fake PipelineRuns that are each individually used by each test case, only provide the single PipelineRun used by each test case. This makes it clearer that each test case is only concerned with a single PipelineRun.
The provided fake Pipelines and Tasks could also be only provided as-needed, but some test cases share Pipelines/Tasks with other test cases, so this is a bit less straightforward.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes