Fix Pipeline/Task to *Run label/annotation propagation 🥨 #4478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
kind/bug
|
The following is the coverage report on the affected files.
|
pritidesai
reviewed
Jan 14, 2022
| @@ -1147,10 +1130,28 @@ func (c *Reconciler) makeConditionCheckContainer(ctx context.Context, rprt *reso | |||
| return &cc, err | |||
| } | |||
|
|
|||
| func storePipelineSpec(ctx context.Context, pr *v1beta1.PipelineRun, ps *v1beta1.PipelineSpec) error { | |||
| func storePipelineSpecAndMergeMeta(ctx context.Context, pr *v1beta1.PipelineRun, ps *v1beta1.PipelineSpec, meta *metav1.ObjectMeta) error { | |||
There was a problem hiding this comment.
since we are updating this function here, please drop ctx since its not used in this function
Before this fix, we are "forgetting" the Task and Pipeline metadata (Labels/Annotations) when using them in a Run (PipelineRun or TaskRun). It is however documented that those metadata get propagated to the generated Pod, and even the code after storing the Spec is written that way. Because we only store the spec, the second time we were reconciling the TaskRun or PipelineRun, we wouldn't fetch the referenced Task or Pipeline anymore, and thus, we would not propagate them. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
force-pushed
the
fix-task-pipeline-run-propagation
branch
from
ee6ec91
to
111d059
Compare
tekton-robot
added
size/L
|
The following is the coverage report on the affected files.
|
|
/retest |
ghost
added
the
needs-cherry-pick
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
ghost
removed
the
needs-cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Before this fix, we are "forgetting" the Task and Pipeline
metadata (Labels/Annotations) when using them in a Run (PipelineRun or
TaskRun).
It is however documented that those metadata get propagated to the
generated Pod, and even the code after storing the Spec is written
that way.
Because we only store the spec, the second time we were reconciling
the TaskRun or PipelineRun, we wouldn't fetch the referenced Task or
Pipeline anymore, and thus, we would not propagate them.
Fixes #4477
Signed-off-by: Vincent Demeester vdemeest@redhat.com
This most likely need an additional unit test or e2e test, I will be working on this 👼🏼
/kind bug
/cc @pritidesai @sbwsg @chmouel @bobcatfish
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes