V1: Add conversion for TaskRun.Resources #5378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/misc
tekton-robot
added
size/M
|
The following is the coverage report on the affected files.
|
lbernick
approved these changes
Aug 25, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
4 tasks
This commit adds support for TaskRun.Resources when converting between v1beta1 and v1 versions of Tasks. This allows us to release v1 TaskRun in a backwards compatible way by ensuring that v1beta1 TaskRuns with Resources serialized into annotations on the v1 TaskRun on conversion.
JeromeJu
force-pushed
the
4985-resources
branch
from
25b2e79
to
58b0e25
Compare
|
The following is the coverage report on the affected files.
|
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for TaskRun.Resources when converting between
v1beta1 and v1 versions of Tasks. This allows us to release v1 TaskRun
in a backwards compatible way by ensuring that v1beta1 TaskRuns with
Resources serialized into annotations on the v1 TaskRun on conversion.
part of #4985
/kind misc
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes