Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0114: Tests Wait Custom Task Retries and TimeOut #5523

Merged
merged 1 commit into from
Sep 27, 2022
Merged

TEP-0114: Tests Wait Custom Task Retries and TimeOut #5523

merged 1 commit into from
Sep 27, 2022

Conversation

XinruZhang
Copy link
Member

Changes

Prior to this pr, we are not able to test cases where Custom Task TimesOut or retries is specified because we don't have a controller ready. Now that we have Wait Task Custom Controller, we are able to write e2e tests to ensure the behavior of timeout and retries.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 19, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 19, 2022
@XinruZhang
Copy link
Member Author

/release-note-none

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 19, 2022
@XinruZhang XinruZhang mentioned this pull request Sep 19, 2022
Closed
dibyom
dibyom reviewed Sep 20, 2022
View reviewed changes
test/custom_task_test.go Outdated Show resolved Hide resolved
dibyom
dibyom reviewed Sep 20, 2022
View reviewed changes
test/custom_task_test.go Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

@XinruZhang: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/retest check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

@XinruZhang: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@XinruZhang XinruZhang requested review from dibyom and removed request for abayer and pritidesai September 22, 2022 13:03
@XinruZhang XinruZhang force-pushed the ctb-testing-retries branch 3 times, most recently from b3fa429 to 522fa37 Compare September 23, 2022 13:35
@dibyom
Copy link
Member

dibyom commented Sep 23, 2022

/test tekton-pipeline-unit-tests

@XinruZhang
TEP-0114: Tests Wait Custom Task Retries and TimeOut
30ea7ae 
Prior to this commit, we are not able to test cases where Custom Task
TimesOut or Retries is specified because we don't have a controller
ready. Now that we implemented the two functionalities in Wait Task
Custom Controller, we are able to write e2e tests to ensure the behavior
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 23, 2022
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2022
jerop
jerop approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Happy to see these e2e tests for custom tasks, thank you @XinruZhang!

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 750f714 into tektoncd:main Sep 27, 2022
@XinruZhang XinruZhang mentioned this pull request Sep 27, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop approved these changes

@dibyom dibyom dibyom approved these changes

Assignees

@dibyom dibyom

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XinruZhang @tekton-robot @dibyom @jerop