Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagated Parameters e2e tests #5599

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Propagated Parameters e2e tests #5599

merged 1 commit into from
Oct 14, 2022

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Oct 4, 2022 •
edited by jerop
Loading

Changes

Prior to this, we only had examples for propagated parameters. This PR adds e2e tests for testing this feature instead of simply relying on the examples.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

None

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 4, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 4, 2022
@chitrangpatel
Copy link
Contributor Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 4, 2022
@chitrangpatel chitrangpatel force-pushed the propagated-params-e2e-tests branch 3 times, most recently from 53ec239 to 830c735 Compare October 5, 2022 13:57
@chitrangpatel
Copy link
Contributor Author

/retest

@chitrangpatel
Copy link
Contributor Author

/retest

1 similar comment
@chitrangpatel
Copy link
Contributor Author

/retest

@chitrangpatel
Copy link
Contributor Author

/retest

@chitrangpatel
Copy link
Contributor Author

/test pull-tekton-pipeline-alpha-integration-tests

@chitrangpatel chitrangpatel force-pushed the propagated-params-e2e-tests branch 4 times, most recently from d5fc40d to 09f3da5 Compare October 11, 2022 17:24
@jerop jerop self-assigned this Oct 11, 2022
@jerop jerop added this to the Pipelines v0.41 milestone Oct 12, 2022
jerop
jerop approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @chitrangpatel!

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2022
dibyom
dibyom reviewed Oct 12, 2022
View reviewed changes
test/propagated_params_test.go Outdated Show resolved Hide resolved
test/propagated_params_test.go Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 13, 2022
jerop
jerop approved these changes Oct 13, 2022
View reviewed changes
test/propagated_params_test.go Outdated Show resolved Hide resolved
test/propagated_params_test.go Outdated Show resolved Hide resolved
test/propagated_params_test.go Outdated Show resolved Hide resolved
test/propagated_params_test.go Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chitrangpatel
Propagated Parameters e2e tests
4977306 
Prior to this, we only had examples for propagated parameters.
This PR adds e2e tests for testing this feature instead of simply
relying on the examples.
@abayer
Copy link
Contributor

abayer commented Oct 14, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2022
@tekton-robot tekton-robot merged commit a42d58a into tektoncd:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom left review comments

@JeromeJu JeromeJu JeromeJu left review comments

@jerop jerop jerop approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@abayer abayer

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.41
Development

Successfully merging this pull request may close these issues.
6 participants
@chitrangpatel @tekton-robot @abayer @dibyom @jerop @JeromeJu