[WIP] Play with #5606

[vaikas]

Signed-off-by: Ville Aikas vaikas@chainguard.dev

Changes

Just playing around for #5606

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign imjasonh after the PR has been reviewed.
You can assign the PR to them by writing /assign @imjasonh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[afrittoli]

/kind misc

[vaikas]

This seems unexpected failure given the changes, any ideas what they are all about?

===========================================
==== TESTING IF YAMLLINT HAS BEEN DONE ====
===========================================
./examples/v1beta1/pipelineruns/alpha/propagating_workspaces_with_referenced_resources.yaml
  7:15      warning  too few spaces before comment  (comments)
  33:19     warning  too few spaces before comment  (comments)
  35:16     warning  too few spaces before comment  (comments)

./examples/v1beta1/pipelineruns/no-ci/hub-resolver.yaml
  23:23     warning  too few spaces before comment  (comments)

./examples/v1beta1/pipelineruns/pipelinerun-with-when-expressions.yaml
  20:27     warning  too few spaces before comment  (comments)
  63:32     warning  too few spaces before comment  (comments)
  85:57     warning  too few spaces before comment  (comments)
  93:40     warning  too few spaces before comment  (comments)
  103:40    warning  too few spaces before comment  (comments)
  115:40    warning  too few spaces before comment  (comments)
  126:48    warning  too few spaces before comment  (comments)
  136:48    warning  too few spaces before comment  (comments)
  146:48    warning  too few spaces before comment  (comments)
  156:48    warning  too few spaces before comment  (comments)
  166:48    warning  too few spaces before comment  (comments)
  176:47    warning  too few spaces before comment  (comments)

./examples/v1beta1/pipelineruns/git-resolver.yaml
  7:20      warning  too few spaces before comment  (comments)
  11:29     warning  too few spaces before comment  (comments)

./examples/v1beta1/pipelineruns/pipelinerun-task-execution-status.yaml
  9:19      warning  too few spaces before comment  (comments)
  16:19     warning  too few spaces before comment  (comments)
  28:19     warning  too few spaces before comment  (comments)
  45:19     warning  too few spaces before comment  (comments)

./examples/v1beta1/pipelineruns/pipelinerun.yaml
  85:35     warning  too few spaces before comment  (comments)

./examples/v1beta1/taskruns/hub-resolver.yaml
  20:22     warning  missing starting space in comment  (comments)
  22:22     warning  missing starting space in comment  (comments)

./config/200-role.yaml
  86:5      warning  comment not indented like content  (comments-indentation)

./config/201-rolebinding.yaml
  96:5      warning  comment not indented like content  (comments-indentation)

./test/yamls/v1beta1/pipelineruns/pipelinerun.yaml
  86:35     warning  too few spaces before comment  (comments)

./.github/workflows/kind-e2e.yaml
  3:1       warning  truthy value should be one of [false, true]  (truthy)
  5:16      error    too many spaces inside brackets  (brackets)
  5:21      error    too many spaces inside brackets  (brackets)
  17:24     warning  too few spaces before comment  (comments)
  26:20     warning  truthy value should be one of [false, true]  (truthy)
  99:87     warning  too few spaces before comment  (comments)

================================
==== YAML LINT TESTS FAILED ====
================================
+ EXIT_VALUE=1
+ set +o xtrace

[tekton-robot]

@vaikas: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-tekton-pipeline-build-tests	1d68c41	link	true	/test pull-tekton-pipeline-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[afrittoli]

./.github/workflows/kind-e2e.yaml

Most of them are warning, the only error is YAML linting in the new workflow:

./.github/workflows/kind-e2e.yaml
  5:16      error    too many spaces inside brackets  (brackets)
  5:21      error    too many spaces inside brackets  (brackets)

[afrittoli]

./.github/workflows/kind-e2e.yaml

Most of them are warning, the only error is YAML linting in the new workflow:

./.github/workflows/kind-e2e.yaml
  5:16      error    too many spaces inside brackets  (brackets)
  5:21      error    too many spaces inside brackets  (brackets)

We should probably fix the warnings as they generate a lot of noise, sorry about that - not in the PR anyways.

[afrittoli]

Since we run the full e2e tests on k8s 1.23, we probably don't need to run the smoke tests on that version.

[vaikas]

Perfect! Missed that. Also is that the best pipelinerun to run, I just picked one to see if anything works :) ? Looks like it's got an image baked into it and I reckon that's what's failing:

            steps:
            - command:
              - /kaniko/executor
              - ""
              - --dockerfile=/workspace/source/examples/microservices/leeroy-app/Dockerfile
              - --context=/workspace/source/examples/microservices/leeroy-app
              - --destination=gcr.io/christiewilson-catfactory/leeroy-app
              - --oci-layout-path=/workspace/source/examples/microservices/leeroy-app/image-digest
              - --build-arg=BASE=alpine:3.9
              - --ignore-path=/product_uuid

[vaikas]

Or just have to configure this:

params.image-registry

to point to registry.local:5000

Just need to figure out where to specify that.

[vaikas]

Maybe just run this?
https://tekton.dev/docs/getting-started/tasks/

[afrittoli]

Maybe just run this? https://tekton.dev/docs/getting-started/tasks/

I think it would be nice to test pipeline, we could use the pipeline getting started and add it to a smoke-test.yaml example.
Alternatively https://github.com/tektoncd/pipeline/blob/main/examples/v1beta1/pipelineruns/pipelinerun-results.yaml could be a good option - it tests the various run CRD and it doesn't require a registry to push to.

[jerop]

@vaikas cleaning up old pull requests, feel free to reopen if you pick this up again 🙏🏾

/close

[tekton-robot]

@jerop: Closed this PR.

In response to this:

@vaikas cleaning up old pull requests, feel free to reopen if you pick this up again 🙏🏾

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.