Cleanup unit tests to use idiomatic Go.

[bendory]

Changes

This PR is a follow-on from #5904 (comment) to make spire tests more readable, easier to understand, and conformant with idiomatic Golang style.

There are no expected functional changes in this PR.

Changes:

• spire_mock_test.go: Renamed test functions from TestSpireMock_* --> TestMock_*
• spire_test.go:
  • Renamed test functions from TestSpire_* --> Test*
  • use concise helper function names -(style guide)
  • in-lined test data in place of testSingleTaskRun(), testSinglePipelineResourceResults() helpers
  • eliminated unnecessary helper functions (genPr() and success := func()...)
  • localized setup to just the tests that need it (style guide)
  • use naming conventions got, want in tests

/kind cleanup

Ref: #5899

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• [N/A] Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• [N/A] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• [N/A] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[bendory]

ping @ijschwabacher

[bendory]

/kind cleanup

[bendory]

/test check-pr-has-kind-label

[tekton-robot]

@bendory: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test pull-tekton-pipeline-alpha-integration-tests
• /test pull-tekton-pipeline-build-tests
• /test pull-tekton-pipeline-integration-tests
• /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

• /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bendory]

/assign @afrittoli

[ijschwabacher]

Wait, we're passing in context.Background() and we want to get context.DeadlineExceeded? So we're effectively testing that the timeout is used here? Is this an admission that there are potentially too many dependencies on that method to move the timeout back out into the caller?

[bendory]

The implementation as written has its own embedded timeout, and IDK the implications of changing that implementation to move the timeout up to the caller. This was a pre-existing test that I have rewritten into idiomatic Go using errors.Is rather than generically checking that an error was returned (which is what the old test did).

I agree that this implementation could be better, but that's not my current focus. 🙈

[tekton-robot]

@bendory:

In response to this:

not today 😸
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bendory]

/test tekton-pipeline-unit-tests

[abayer]

/lgtm