-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean Up: Update []Param
to the new Params
type
#6446
Conversation
8310641
to
90d0e90
Compare
[]Param
to the new Params
type.[]Param
to the new Params
type
90d0e90
to
e01e78a
Compare
This commit updates []Param to the new Params type everywhere in the code base. This is a follow up to PR tektoncd#6180 where the type type Params []Param was introduced to allow member functions. This change will make it easier to make changes related to the type.
e01e78a
to
7980732
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this cleanup @EmmaMunley!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Thanks! |
Changes
This PR updates
[]Param
to the newParams
type everywhere in the code base. This is a follow up to PR #6180 where the typetype Params []Param
was introduced to allow member functions. This change will make it easier to make changes related to the type./kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes