Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hygiene: enable exhaustive linter. #6484

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Hygiene: enable exhaustive linter. #6484

merged 1 commit into from
Apr 10, 2023

Conversation

bendory
Copy link
Contributor

@bendory bendory commented Apr 3, 2023

Changes

The exhaustive linter checks exhaustiveness of switch statements, ensuring completeness of given cases.

There are no expected functional changes in this CL.

Context: #5899

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [N/A] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • [N/A] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [N/A] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [N/A] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 3, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% 0.0
pkg/apis/pipeline/v1/task_validation.go 96.9% 96.9% 0.0
pkg/apis/pipeline/v1beta1/param_types.go 99.1% 99.1% 0.0
pkg/apis/pipeline/v1beta1/task_validation.go 97.0% 97.0% 0.0
pkg/credentials/dockercreds/creds.go 87.0% 86.0% -0.9
pkg/credentials/gitcreds/creds.go 88.9% 84.2% -4.7
pkg/reconciler/pipelinerun/resources/apply.go 98.1% 98.1% 0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 92.9% 93.8% 0.9
pkg/reconciler/taskrun/resources/apply.go 99.2% 99.2% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% 0.0
pkg/apis/pipeline/v1/task_validation.go 96.9% 96.9% 0.0
pkg/apis/pipeline/v1beta1/param_types.go 99.1% 99.1% 0.0
pkg/apis/pipeline/v1beta1/task_validation.go 97.0% 97.0% 0.0
pkg/credentials/dockercreds/creds.go 87.0% 86.0% -0.9
pkg/credentials/gitcreds/creds.go 88.9% 84.2% -4.7
pkg/reconciler/pipelinerun/resources/apply.go 98.1% 98.1% 0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 92.9% 92.9% 0.1
pkg/reconciler/taskrun/resources/apply.go 99.2% 99.2% 0.0

@bendory
Copy link
Contributor Author

bendory commented Apr 3, 2023

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@bendory: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% 0.0
pkg/apis/pipeline/v1/task_validation.go 96.9% 96.9% 0.0
pkg/apis/pipeline/v1beta1/param_types.go 99.1% 99.1% 0.0
pkg/apis/pipeline/v1beta1/task_validation.go 97.0% 97.0% 0.0
pkg/credentials/dockercreds/creds.go 87.0% 86.0% -0.9
pkg/credentials/gitcreds/creds.go 88.9% 84.2% -4.7
pkg/reconciler/pipelinerun/resources/apply.go 98.1% 98.1% 0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.0% 89.1% 0.1
pkg/reconciler/taskrun/resources/apply.go 99.2% 99.2% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% 0.0
pkg/apis/pipeline/v1/task_validation.go 96.9% 96.9% 0.0
pkg/apis/pipeline/v1beta1/param_types.go 99.1% 99.1% 0.0
pkg/apis/pipeline/v1beta1/task_validation.go 97.0% 97.0% 0.0
pkg/credentials/dockercreds/creds.go 87.0% 86.0% -0.9
pkg/credentials/gitcreds/creds.go 88.9% 84.2% -4.7
pkg/reconciler/pipelinerun/resources/apply.go 98.1% 98.1% 0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.0% 89.1% 0.1
pkg/reconciler/taskrun/resources/apply.go 99.2% 99.2% 0.0

Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add test cases for the new cases in switch statements? the coverage for some files has dropped

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% 0.0
pkg/apis/pipeline/v1/task_validation.go 96.9% 96.9% 0.0
pkg/apis/pipeline/v1beta1/param_types.go 99.1% 99.1% 0.0
pkg/apis/pipeline/v1beta1/task_validation.go 97.0% 97.0% 0.0
pkg/credentials/dockercreds/creds.go 87.0% 86.0% -0.9
pkg/credentials/gitcreds/creds.go 88.9% 84.2% -4.7
pkg/reconciler/pipelinerun/resources/apply.go 98.1% 98.1% 0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.0% 89.1% 0.1
pkg/reconciler/taskrun/resources/apply.go 99.2% 99.2% 0.0

The [exhaustive](https://pkg.go.dev/github.com/nishanths/exhaustive)
linter checks exhaustiveness of switch statements, ensuring completeness
of case statements.

There are no expected functional changes in this CL.

Context: #5899
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% 0.0
pkg/apis/pipeline/v1/task_validation.go 96.9% 96.9% 0.0
pkg/apis/pipeline/v1beta1/param_types.go 99.1% 99.1% 0.0
pkg/apis/pipeline/v1beta1/task_validation.go 97.0% 97.0% 0.0
pkg/credentials/dockercreds/creds.go 87.0% 89.2% 2.3
pkg/credentials/gitcreds/creds.go 88.9% 94.7% 5.8
pkg/reconciler/pipelinerun/resources/apply.go 98.1% 98.1% 0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.0% 89.1% 0.1
pkg/reconciler/taskrun/resources/apply.go 99.2% 99.2% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.1% 99.1% 0.0
pkg/apis/pipeline/v1/task_validation.go 96.9% 96.9% 0.0
pkg/apis/pipeline/v1beta1/param_types.go 99.1% 99.1% 0.0
pkg/apis/pipeline/v1beta1/task_validation.go 97.0% 97.0% 0.0
pkg/credentials/dockercreds/creds.go 87.0% 89.2% 2.3
pkg/credentials/gitcreds/creds.go 88.9% 94.7% 5.8
pkg/reconciler/pipelinerun/resources/apply.go 98.1% 98.1% 0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 89.0% 89.1% 0.1
pkg/reconciler/taskrun/resources/apply.go 99.2% 99.2% 0.0

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2023
@bendory
Copy link
Contributor Author

bendory commented Apr 9, 2023

can you add test cases for the new cases in switch statements? the coverage for some files has dropped

Done.

Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2023
@bendory
Copy link
Contributor Author

bendory commented Apr 10, 2023

/joke

I just noticed that this is a valid command, I apologize for my curiosity.

@tekton-robot
Copy link
Collaborator

@bendory: A weasel walks into a bar. The bartender says, "Wow, I've never served a weasel before. What can I get for you?" "Pop," goes the weasel.

In response to this:

/joke

I just noticed that this is a valid command, I apologize for my curiosity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot merged commit 56be556 into tektoncd:main Apr 10, 2023
@bendory bendory deleted the e2 branch April 10, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants