Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API compatibility policy for stable CRDs #6532

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Update API compatibility policy for stable CRDs #6532

merged 1 commit into from
Apr 21, 2023

Conversation

lbernick
Copy link
Member

This commit updates the API stability policy to clarify the stability levels of existing CRDs.

/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • n/a Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • n/a Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • n/a Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesnt merit a release note. labels Apr 13, 2023
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 13, 2023
@jerop
Copy link
Member

jerop commented Apr 17, 2023

/assign

vdemeester
vdemeester approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to use version in there (e.g. v1.Task). Because one day we might have v2alpha1.Task.. which will be unstable (but v1.Task will still be).
But that can probably taken into account then.

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2023
jerop
jerop reviewed Apr 17, 2023
View reviewed changes
api_compatibility_policy.md Outdated Show resolved Hide resolved
@lbernick
Copy link
Member Author

We may want to use version in there (e.g. v1.Task). Because one day we might have v2alpha1.Task.. which will be unstable (but v1.Task will still be). But that can probably taken into account then.

done!

@lbernick lbernick mentioned this pull request Apr 18, 2023
Closed
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lbernick
Copy link
Member Author

2023/04/18 15:50:35 error running c.PullRequests.ListFiles(Ctx, repoOwner=tektoncd, RepoName=pipeline, pullNum=6532, listOptions): Get "https://api.github.com/repos/tektoncd/pipeline/pulls/6532/files?page=1": net/http: TLS handshake timeout

/retest

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2023
@lbernick
Update API compatibility policy for stable CRDs
064b939 
This commit updates the API stability policy to clarify the stability levels
of existing CRDs.
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2023
Yongxuanzhang
Yongxuanzhang reviewed Apr 21, 2023
View reviewed changes
Copy link
Member

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2023
@tekton-robot tekton-robot merged commit a0b5cc5 into tektoncd:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang left review comments

@vdemeester vdemeester vdemeester approved these changes

@jerop jerop jerop approved these changes

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@jerop jerop

@Yongxuanzhang Yongxuanzhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lbernick @jerop @tekton-robot @vdemeester @Yongxuanzhang