-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recover Conversion Functions from Pipeline Resources for backwards compatibility #7109
Recover Conversion Functions from Pipeline Resources for backwards compatibility #7109
Conversation
When we reverted removal of `PipelineResources` [related fields](tektoncd#6436), we did not recover the conversion functions. As a result, when migrating Tekton Chains to watch `v1` objects, we run into Issue tektoncd#7105. This PR recovers the conversion functions so that we can continue to convert PipelineResources related fields.
/assign @wlynch |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wlynch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
When we reverted removal of
PipelineResources
related fields,we did not recover the conversion functions. As a result, when migrating
Tekton Chains to watch
v1
objects, we run into Issue #7105.This PR recovers the conversion functions so that we can continue to convert PipelineResources related fields. It addresses issue #7105.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/kind bug