Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let the user pass a secret via a parameter for SCM API operations when using the git API resolver #7239

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Let the user pass a secret via a parameter for SCM API operations when using the git API resolver #7239

merged 1 commit into from
Oct 30, 2023

Commits on Oct 30, 2023

  1. Let the user pass a secret for on git API resolver 

    We were previously only allowing using a secret from the global
configmap, which mean every users on the cluster would have to use the
same git value (which could be a security issue).

We now let the user use their own token on their own namespace with the
optional "token" and (even more optional) "tokenKey" params.

The fallback will still be the global configmap.

Added a bit logic to make sure we are caching secrets only when user use
the token from global configmap. Since we can't ensure for local secrets
on namespace may be rotated often.

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
    @chmouel
    chmouel committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    170ce5b View commit details
    Browse the repository at this point in the history