Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP-0142] Add ResolverRef to Ref #7322

Merged
merged 1 commit into from
Nov 3, 2023
Merged

[TEP-0142] Add ResolverRef to Ref #7322

merged 1 commit into from
Nov 3, 2023

Conversation

Yongxuanzhang
Copy link
Member

@Yongxuanzhang Yongxuanzhang commented Nov 1, 2023 •
edited
Loading

Changes

This commit is part of #7259. First step to support remote resoluton for StepAction. It adds ResolverRef to Ref, validation and conversion.

/kind featuree

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot
Copy link
Collaborator

@Yongxuanzhang: The label(s) kind/featuree cannot be applied, because the repository doesn't have them.

In response to this:

Changes

This commit is part of #7259. First step to support remote resoluton for StepAction. It adds ResolverRef to Ref, validation and conversion.

/kind featuree

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 1, 2023
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 1, 2023
@Yongxuanzhang
Copy link
Member Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 1, 2023
@Yongxuanzhang Yongxuanzhang marked this pull request as ready for review November 1, 2023 21:26
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/container_validation.go Do not exist 22.2%
pkg/apis/pipeline/v1/task_validation.go 98.1% 98.2% 0.0
pkg/apis/pipeline/v1beta1/container_validation.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/container_validation.go Do not exist 22.2%
pkg/apis/pipeline/v1/task_validation.go 98.1% 98.2% 0.0
pkg/apis/pipeline/v1beta1/container_validation.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/container_validation.go Do not exist 100.0%
pkg/apis/pipeline/v1/task_validation.go 98.1% 98.2% 0.0
pkg/apis/pipeline/v1beta1/container_validation.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/container_validation.go Do not exist 100.0%
pkg/apis/pipeline/v1/task_validation.go 98.1% 98.2% 0.0
pkg/apis/pipeline/v1beta1/container_validation.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/container_validation.go Do not exist 100.0%
pkg/apis/pipeline/v1/task_validation.go 98.1% 98.2% 0.0
pkg/apis/pipeline/v1beta1/container_validation.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/container_validation.go Do not exist 100.0%
pkg/apis/pipeline/v1/task_validation.go 98.1% 98.2% 0.0
pkg/apis/pipeline/v1beta1/container_validation.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0

@chitrangpatel
Copy link
Contributor

chitrangpatel commented Nov 2, 2023 •
edited
Loading

@Yongxuanzhang can you add docs for this in stepacitons.md under Referencing a StepAction?
Otherwise lgtm

@chitrangpatel
Copy link
Contributor

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
@Yongxuanzhang
Copy link
Member Author

@Yongxuanzhang can you add docs for this in stepacitons.md under Referencing a StepAction? Otherwise lgtm

Thanks! We can add docs when the feature is functional in the next/following PRs. Should be in very soon. 😄

@jerop
Copy link
Member

jerop commented Nov 2, 2023

@tektoncd/core-maintainers @tektoncd/core-collaborators please take a look 🙏🏾

jerop
jerop approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

QuanZhang-William
QuanZhang-William reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@QuanZhang-William QuanZhang-William left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments. Also, would you consider applying default resolver for StepAction @chitrangpatel @Yongxuanzhang ?

#6317 and
https://github.com/tektoncd/community/blob/main/teps/0133-configure-default-resolver.md

pkg/apis/pipeline/v1/container_validation.go Outdated Show resolved Hide resolved
pkg/apis/pipeline/v1beta1/container_types.go Show resolved Hide resolved
pkg/apis/pipeline/v1/container_types.go Show resolved Hide resolved
pkg/apis/pipeline/v1beta1/container_validation.go Outdated Show resolved Hide resolved
@Yongxuanzhang
[TEP-0142] Add ResolverRef to Ref
d381bc8 
This commit is part of tektoncd#7259. First step to support remote resoluton for
StepAction. It adds ResolverRef to Ref, validation and conversion.

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
@Yongxuanzhang
Copy link
Member Author

Left some minor comments. Also, would you consider applying default resolver for StepAction @chitrangpatel @Yongxuanzhang ?

#6317 and https://github.com/tektoncd/community/blob/main/teps/0133-configure-default-resolver.md

Oh that's a good call. Let me take a look

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/container_validation.go Do not exist 100.0%
pkg/apis/pipeline/v1/task_validation.go 98.2% 98.2% 0.0
pkg/apis/pipeline/v1beta1/container_validation.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/container_validation.go Do not exist 100.0%
pkg/apis/pipeline/v1/task_validation.go 98.2% 98.2% 0.0
pkg/apis/pipeline/v1beta1/container_validation.go Do not exist 100.0%
pkg/apis/pipeline/v1beta1/task_validation.go 98.2% 98.2% 0.0

@Yongxuanzhang Yongxuanzhang mentioned this pull request Nov 2, 2023
Closed
@Yongxuanzhang
Copy link
Member Author

Left some minor comments. Also, would you consider applying default resolver for StepAction @chitrangpatel @Yongxuanzhang ?
#6317 and https://github.com/tektoncd/community/blob/main/teps/0133-configure-default-resolver.md

Oh that's a good call. Let me take a look

Create an issue to track: #7329
We can add it in a separate pr

@Yongxuanzhang Yongxuanzhang mentioned this pull request Nov 2, 2023
Closed
20 tasks
@jerop
Copy link
Member

jerop commented Nov 3, 2023

@tektoncd/core-maintainers @tektoncd/core-collaborators please take a look 🙏🏾

@chitrangpatel
Copy link
Contributor

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chitrangpatel,jerop]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@QuanZhang-William
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2023
@tekton-robot tekton-robot merged commit 206ef2c into tektoncd:main Nov 3, 2023
12 checks passed
@jerop jerop added this to the Pipelines v0.54 milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuanZhang-William QuanZhang-William QuanZhang-William left review comments

@JeromeJu JeromeJu JeromeJu left review comments

@jerop jerop jerop approved these changes

@vdemeester vdemeester Awaiting requested review from vdemeester

@abayer abayer Awaiting requested review from abayer

@pritidesai pritidesai Awaiting requested review from pritidesai

@chitrangpatel chitrangpatel Awaiting requested review from chitrangpatel

Assignees

@QuanZhang-William QuanZhang-William

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.54
Development

Successfully merging this pull request may close these issues.
6 participants
@Yongxuanzhang @tekton-robot @chitrangpatel @jerop @QuanZhang-William @JeromeJu