-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup the teps CI job with git rebase on master #655
Conversation
Note that this uses a new ingress, a new event listener and a new folder in git to keep the workspace based CI separated from the pipeline resources based one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me although I will say that I don't think I'm expert enough to tell whether it's ready to merge and use yet?
/test check-pr-has-kind-label |
1 similar comment
/test check-pr-has-kind-label |
cac36aa
to
f842879
Compare
/lgtm |
f842879
to
f074bb3
Compare
Uhm, something is not right with the |
Heh, the problem is that the base branch in the |
f074bb3
to
dae6e57
Compare
/test .* |
12bf992
to
ffc699d
Compare
The "git batch merge" task in the catalog already does the job of rebasing (or actually merging) the commits from a PR on top of master - see https://hub.tekton.dev/tekton/task/git-batch-merge. Using that task though requires workspaces. I'm using this CI job then to start the work of removing deprecated resources from our dogfooding and switching to workspaces and when expressions. This PR adds a new endpoint for webhooks so that we may migrate jobs over time from one webhook to the other. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/meow
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
In tektoncd#655 a version of the teps linter was added which uses workspaces instead of PipelineResources. Looking through pipelineruns, it looks like this older version of the linter is no longer triggered, and the new one is, so it should be safe to delete.
In tektoncd#655 a version of the teps linter was added which uses workspaces instead of PipelineResources. Looking through pipelineruns, it looks like this older version of the linter is no longer triggered, and the new one is, so it should be safe to delete.
In #655 a version of the teps linter was added which uses workspaces instead of PipelineResources. Looking through pipelineruns, it looks like this older version of the linter is no longer triggered, and the new one is, so it should be safe to delete.
Changes
The "git batch merge" task in the catalog already does the job of
rebasing (or actually merging) the commits from a PR on top of
master - see https://hub.tekton.dev/tekton/task/git-batch-merge.
Using that task though requires workspaces. I'm using this CI job
then to start the work of removing deprecated resources from our
dogfooding and switching to workspaces and when expressions.
This PR adds a new endpoint for webhooks so that we may
migrate jobs over time from one webhook to the other.
Signed-off-by: Andrea Frittoli andrea.frittoli@uk.ibm.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
/kind feature