Fix rank function. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds like a sensible approach - I'm not an expert on the numerical validity of this kind of approximation though. Happy to merge it if there is consensus that this is the right approach? |
|
Nobody is here to vote :) @mikera could you merge it? I think it's better to fix the bug and if someone come up with better API later he could easily create new pull request. |
|
OK done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check #34. I'm not sure what the best way to check value for zero except comparing it to some epsilon constant. So I implemented this approach here.
*eps*constant dynamic so it can be rebinded for user needs.