Skip to content

Conversation

bobeal
Copy link
Contributor

@bobeal bobeal commented Oct 21, 2020

Hi all,

As discussed in #888 (with a lot of delay, sorry for that), here is the PR to activate update mode when calling the batch upsert NGSI-LD API to update entities.

Default mode for batch upsert is to replace entities, which does not exactly match with what we want to do (basically updating a value measured by a sensor).

@fgalan
Copy link
Member

fgalan commented Oct 22, 2020

From my point of view, the PR is ok, but maybe feedback for other people more involved in NGSI-LD (maybe @jason-fox) would be desirable.

From a CHANGES_NEXT_RELEASE perspective maybe this PR should add a sub-bullet on the Add basic NGSI-LD support as experimental feature (#842) section.

@jason-fox
Copy link
Contributor

LGTM

Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 0d25170 into telefonicaid:feature/842_ngsi_ld Oct 22, 2020
@bobeal bobeal deleted the feature/use-update-mode-when-updating-entities branch December 16, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants