Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some accessibility labels are not translated #1205

Closed
Scrumplex opened this issue Sep 13, 2022 · 1 comment
Closed

Some accessibility labels are not translated #1205

Scrumplex opened this issue Sep 13, 2022 · 1 comment
Labels
accessibility Related to accessibility bug Something isn't working

Comments

@Scrumplex
Copy link

Scale Version
3.0.0-beta.111

Framework and version
No Framework

Current Behavior
Some accessibility labels are not translated to German, for pages with <html lang="de" ...

Affected components:

  • scale-notification-message's close button has aria-label="close"
  • scale-app-header's sector-navigation
    • active sector is labelled as active despite the language settings
      image
    • additionally the sector navigration item has aria-current="true" which means there are two indicators that will be read by screen readers

Code Reproduction

<scale-notification-message dismissible opened>
  Notification text goes here
</scale-notification-message>
<scale-app-shell claim-lang="de" logo-title="App Name" logo-href="/" sector-navigation='[{"name":"Personal","id":"Personal38","href":"#personal"},{"name":"Business","id":"Business39","href":"#business"}]' active-sector-id="Personal38">
  <div style="height: 800px; padding: 48px 0;">
    Scroll to test header behavior
  </div>
  <div style="height: 800px; padding: 48px 0;">
    Scroll more to test header behavior
  </div>
</scale-app-shell>

Desktop (please complete the following information):

  • OS: macOS
  • Browser Microsoft Edge, Firefox
  • Version Firefox 104.0.2, Microsoft Edge 105.0.1343.33

Smartphone (please complete the following information):
N/A

Additional context
@Scrumplex Scrumplex added the bug Something isn't working label Sep 13, 2022
@acstll acstll added the accessibility Related to accessibility label Sep 22, 2022
@felix-ico
Copy link
Collaborator

Hi @Scrumplex sorry for the very late reply. I think the accessibility labels need to be set by the consumer, and are not automatically derived by the lang attribute. The header you mention has also been deprecated, and the new telekom-header should have many improvements in regards to accessibility, so these issues should all be solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility Related to accessibility bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@acstll @Scrumplex @felix-ico