Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent flicker #2230

Merged
merged 3 commits into from
Dec 11, 2023
Merged

fix: prevent flicker #2230

merged 3 commits into from
Dec 11, 2023

Conversation

felix-ico
Copy link
Collaborator

@felix-ico felix-ico commented Dec 5, 2023 •
edited
Loading

fix #2130

@netlify Netlify
Copy link

netlify bot commented Dec 5, 2023 •
edited
Loading

✅ Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit 0849fdb
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/6571a53a3ec43a00080f8632
😎 Deploy Preview https://deploy-preview-2230--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@felix-ico felix-ico changed the title fix: prevent flixker fix: prevent flicker Dec 5, 2023
@github-actions github-actions bot mentioned this pull request Dec 6, 2023
Closed
acstll
acstll approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@acstll acstll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@acstll acstll merged commit 03cdd4c into main Dec 11, 2023
12 checks passed
@acstll acstll deleted the fix/header-flicker branch December 11, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acstll acstll acstll approved these changes

@maomaoZH maomaoZH Awaiting requested review from maomaoZH maomaoZH is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

app-shell: footer is unreachable when page's heightoverflows only couple of pixels.
2 participants
@felix-ico @acstll