Update nuget.md #133
Merged
Update nuget.md #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refined GitHub Secrets section with the following changes: * Changed example repo to the DevOpsExamples repo where I have recently added 3 new GitHub actions that use secrets to authenticate with the Telerik NuGet server. * Added the `packageSource` section to the nunget config file snippet. This is important because the key of the package source needs to match the xml node for the packagesourceCredential. * Changed the packageSource name from `Telerik` to `TelerikFeed` to make the relationship between the packagesource key and the credentials key * Added an important note about how GitHub keeps the secret encrypted and masked, even after being copied into an environment variable. * Added an important warning about GitHub's restriction of allowing secrets to be used in GH actions that were invoked by pull-request event * Small refinements to language describing the example (e.g. "get" to "set")
marin-bratanov
pushed a commit
that referenced
this pull request
Sep 10, 2020
Refined GitHub Secrets section with the following changes: * Changed example repo to the DevOpsExamples repo where I have recently added 3 new GitHub actions that use secrets to authenticate with the Telerik NuGet server. * Added the `packageSource` section to the nunget config file snippet. This is important because the key of the package source needs to match the xml node for the packagesourceCredential. * Changed the packageSource name from `Telerik` to `TelerikFeed` to make the relationship between the packagesource key and the credentials key * Added an important note about how GitHub keeps the secret encrypted and masked, even after being copied into an environment variable. * Added an important warning about GitHub's restriction of allowing secrets to be used in GH actions that were invoked by pull-request event * Small refinements to language describing the example (e.g. "get" to "set")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refined GitHub Secrets section with the following changes:
packageSourcesection to the nunget config file snippet. This is important because the key of the package source needs to match the xml node for the packagesourceCredential.TeleriktoTelerikFeedto make the relationship between the packagesource key and the credentials key