Skip to content

[4.6] docs(charts): add charts trendline documentation #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2023
Merged

[4.6] docs(charts): add charts trendline documentation #1671

merged 2 commits into from
Oct 10, 2023

Conversation

xristianstefanov
Copy link
Contributor

@xristianstefanov xristianstefanov requested a review from a team October 10, 2023 09:05
@xristianstefanov xristianstefanov requested a review from a team as a code owner October 10, 2023 09:05
@xristianstefanov xristianstefanov self-assigned this Oct 10, 2023
dimodi
dimodi reviewed Oct 10, 2023
View reviewed changes
dimodi
dimodi reviewed Oct 10, 2023
View reviewed changes
dimodi
dimodi reviewed Oct 10, 2023
View reviewed changes
dimodi
dimodi reviewed Oct 10, 2023
View reviewed changes
dimodi
dimodi reviewed Oct 10, 2023
View reviewed changes
dimodi
dimodi reviewed Oct 10, 2023
View reviewed changes
dimodi
dimodi reviewed Oct 10, 2023
View reviewed changes
dimodi
dimodi reviewed Oct 10, 2023
View reviewed changes
dimodi
dimodi reviewed Oct 10, 2023
View reviewed changes
dimodi
dimodi requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@dimodi dimodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Captions should look like headings rather than sentences.
  • Follow docs code style and refactor the data generation.
  • Consider a list instead of a one-column table.
  • Polish trendline parameter table.

yordan-mitev
yordan-mitev reviewed Oct 10, 2023
View reviewed changes
@xristianstefanov xristianstefanov merged commit 7658696 into master Oct 10, 2023
@github-actions github-actions bot deleted the docs-charts-trendline-support branch October 10, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimodi dimodi dimodi approved these changes

@yordan-mitev yordan-mitev Awaiting requested review from yordan-mitev

Assignees

@xristianstefanov xristianstefanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xristianstefanov @dimodi @yordan-mitev