Skip to content

docs(scheduler):resource grouping documentation added #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 22, 2021

Conversation

xristianstefanov
Copy link
Contributor

  • Added Grouping in the Scheduler documentation
  • New sections for Resource Grouping in all the available views

@xristianstefanov xristianstefanov requested a review from a team June 16, 2021 19:59
@xristianstefanov xristianstefanov self-assigned this Jun 16, 2021
@xristianstefanov xristianstefanov requested review from a team and marin-bratanov June 18, 2021 07:09
@marin-bratanov
Copy link
Contributor

I recommend you rename the #code-snippet name in (/_contentTemplates/scheduler/views.md#code-snippet) to make it more meaningful. Will try to build and review in more detail over the weekend.

Copy link
Contributor

@marin-bratanov marin-bratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OnInitializedAsync in the component should not have to generate resources, the service should provide them. Make sure that code is cleaned up.

Rename the headings for resource grouping in the inidividual view articles to include the view name (e.g. "Resource Grouping in the Day View") as that's the first examples people will see when landing on the Resource Grouping page.

In the Resource Grouping article, consider moving the links to the four views examples in the basics section - so people have seen one example and are familiar with the new tag and its settings before looking at rather complex code.

Add a screenshot for grouping by multiple resources. In fact, consider making headings for them, it is a nice thing to point out to people. You can have three sections - Basics, Single resource grouping (that also links to individual views examples) and Multipel Resource Grouping.

@xristianstefanov xristianstefanov requested review from marin-bratanov and a team June 21, 2021 11:47
xristianstefanov and others added 6 commits June 21, 2021 17:29
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
xristianstefanov and others added 3 commits June 21, 2021 18:23
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Copy link
Contributor

@marin-bratanov marin-bratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, I have not had time to check

@xristianstefanov xristianstefanov merged commit 877ef14 into master Jun 22, 2021
@xristianstefanov xristianstefanov deleted the scheduler-resource-grouping-documentation branch June 22, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants