Skip to content

Scheduler events #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 14, 2021
Merged

Scheduler events #500

merged 5 commits into from
Sep 14, 2021

Conversation

svdimitr
Copy link
Contributor

No description provided.

@svdimitr svdimitr requested a review from a team September 14, 2021 08:19
@svdimitr svdimitr self-assigned this Sep 14, 2021
@github-actions
Copy link
Contributor

Hello @svdimitr,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create pr to production

dimodi
dimodi reviewed Sep 14, 2021
View reviewed changes
dimodi
dimodi reviewed Sep 14, 2021
View reviewed changes
dimodi
dimodi reviewed Sep 14, 2021
View reviewed changes
@dimodi
Copy link
Contributor

dimodi commented Sep 14, 2021

The identical explanations bug me a bit. If a reader checks all three events, they may feel as if a robot has produced the description. Isn't it possible to somehow merge the information for the three events?

@svdimitr
Copy link
Contributor Author

The identical explanations bug me a bit. If a reader checks all three events, they may feel as if a robot has produced the description. Isn't it possible to somehow merge the information for the three events?

We did that multiple times for the sake of different code snippets and docs brevity. If we decide to take this route we should update the other components' Events articles as well.

svdimitr and others added 3 commits September 14, 2021 17:48
@svdimitr @dimodi
Update components/scheduler/events.md
a80aee1 
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
@svdimitr @dimodi
Update components/scheduler/events.md
e848e91 
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
@svdimitr @dimodi
Update components/scheduler/events.md
4cf81d7 
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
@svdimitr svdimitr merged commit b17657f into master Sep 14, 2021
@github-actions github-actions bot deleted the scheduler-events branch September 14, 2021 14:49
dimodi added a commit that referenced this pull request Sep 14, 2021
@svdimitr @dimodi
Scheduler events (#500)
2c87f24 
* chore(events): add events

* chore(events): add EventArgs to the events

* Update components/scheduler/events.md

Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>

* Update components/scheduler/events.md

Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>

* Update components/scheduler/events.md

Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>

Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimodi dimodi dimodi approved these changes

Assignees

@svdimitr svdimitr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svdimitr @dimodi