Skip to content

Conversation

xristianstefanov
Copy link
Contributor

@xristianstefanov xristianstefanov commented Dec 1, 2021

  • Added new sections with documentation for Overview, Header, Visibility, Action Buttons.

@xristianstefanov xristianstefanov requested a review from a team December 1, 2021 23:42
@xristianstefanov xristianstefanov self-assigned this Dec 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2021

Hello @xristianstefanov,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create pr to production

Copy link
Contributor

@dimodi dimodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top suggestions:

  • Improve the Overview introduction.
  • Make the Basics mode basic :)
  • Make the Basics code snippet match the steps above it.
  • Use simple, but real-world text for the Dialogs, instead of dummy text.
  • Consider using a Primary OK button.
  • Consider an Events article that shows one-way binding for Visible.
  • Reconsider the need for a Visibility article.

xristianstefanov and others added 6 commits December 3, 2021 00:54
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
xristianstefanov and others added 3 commits December 3, 2021 00:56
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
@xristianstefanov xristianstefanov merged commit 1492876 into master Dec 6, 2021
@github-actions github-actions bot deleted the docs-dialog-component branch December 6, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants