-
Notifications
You must be signed in to change notification settings - Fork 80
docs(dialog):documentation for the dialog component #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @xristianstefanov, Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.
|
dimodi
reviewed
Dec 2, 2021
dimodi
reviewed
Dec 2, 2021
dimodi
reviewed
Dec 2, 2021
dimodi
reviewed
Dec 2, 2021
dimodi
reviewed
Dec 2, 2021
dimodi
reviewed
Dec 2, 2021
dimodi
reviewed
Dec 2, 2021
dimodi
reviewed
Dec 2, 2021
dimodi
reviewed
Dec 2, 2021
dimodi
reviewed
Dec 2, 2021
dimodi
reviewed
Dec 2, 2021
dimodi
reviewed
Dec 2, 2021
dimodi
reviewed
Dec 2, 2021
dimodi
reviewed
Dec 2, 2021
dimodi
reviewed
Dec 2, 2021
dimodi
reviewed
Dec 2, 2021
dimodi
reviewed
Dec 2, 2021
dimodi
reviewed
Dec 2, 2021
dimodi
reviewed
Dec 2, 2021
dimodi
requested changes
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top suggestions:
- Improve the Overview introduction.
- Make the Basics mode basic :)
- Make the Basics code snippet match the steps above it.
- Use simple, but real-world text for the Dialogs, instead of dummy text.
- Consider using a Primary OK button.
- Consider an Events article that shows one-way binding for Visible.
- Reconsider the need for a Visibility article.
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
dimodi
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.