Update disabled-button.md #818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is meant to clarify that a developer is still responsible to verify the button's "Enabled" state in the "OnClick" event handler. For further details see https://feedback.telerik.com/blazor/1555442-telerikbutton-disabled-state-can-be-circumvented-to-trigger-onclick
dimodi
reviewed
Mar 9, 2022
|
Thanks for the pull request, @adiessl ! I am waiting for a second opinion on this behavior, so I will leave the PR open a bit longer. |
|
By the way, have you signed the Contribution License Agreement? I don't see you there, but this is required for us to merge your PR. |
|
I have signed the Contribution License Agreement. |
dimodi
reviewed
Mar 9, 2022
dimodi
approved these changes
Mar 9, 2022
dimodi
added a commit
that referenced
this pull request
Mar 9, 2022
* Update disabled-button.md This is meant to clarify that a developer is still responsible to verify the button's "Enabled" state in the "OnClick" event handler. For further details see https://feedback.telerik.com/blazor/1555442-telerikbutton-disabled-state-can-be-circumvented-to-trigger-onclick * Update components/button/disabled-button.md * Update components/button/disabled-button.md Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to clarify that a developer is still responsible to verify the button's "Enabled" state in the "OnClick" event handler.
For further details see https://feedback.telerik.com/blazor/1555442-telerikbutton-disabled-state-can-be-circumvented-to-trigger-onclick