feat(community-testimonial): remove card from community-testimonial

BREAKING CHANGE: removes card from community-testimonial component #192
telus · May 22, 2019 · 48158ca · 48158ca
1 parent 3b746dd
commit 48158ca
Show file tree

Hide file tree

Showing 4 changed files with 51 additions and 59 deletions.
diff --git a/e2e/output/components/Testimonial/baseline/chrome_headless.png b/e2e/output/components/Testimonial/baseline/chrome_headless.png
diff --git a/packages/Testimonial/Testimonial.jsx b/packages/Testimonial/Testimonial.jsx
@@ -2,7 +2,6 @@ import React from 'react'
 import PropTypes from 'prop-types'
 
 import Box from '@tds/core-box'
-import Card from '@tds/core-card'
 import Paragraph from '@tds/core-paragraph'
 import safeRest from '@tds/shared-safe-rest'
 import { componentWithName } from '@tds/util-prop-types'
@@ -15,18 +14,16 @@ import styles from './Testimonial.scss'
  */
 const Testimonial = ({ testimonial, image, title, additionalInfo, ...rest }) => {
   return (
-    <Card {...safeRest(rest)}>
-      <Box between={3}>
-        <Paragraph>{testimonial}</Paragraph>
-        <div className={styles.imageAndQuote}>
-          {image && <div className={styles.image}>{image}</div>}
-          <div>
-            <Paragraph bold>{title}</Paragraph>
-            <Paragraph>{additionalInfo}</Paragraph>
-          </div>
+    <Box {...safeRest(rest)} between={3}>
+      <Paragraph>{testimonial}</Paragraph>
+      <div className={styles.imageAndQuote}>
+        {image && <div className={styles.image}>{image}</div>}
+        <div>
+          <Paragraph bold>{title}</Paragraph>
+          <Paragraph>{additionalInfo}</Paragraph>
         </div>
-      </Box>
-    </Card>
+      </div>
+    </Box>
   )
 }
 

diff --git a/packages/Testimonial/__tests__/__snapshots__/Testimonial.spec.jsx.snap b/packages/Testimonial/__tests__/__snapshots__/Testimonial.spec.jsx.snap
@@ -1,55 +1,51 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`Testimonial renders 1`] = `
-<Card
-  variant="white"
+<Box
+  between={3}
+  inline={false}
+  tag="div"
 >
-  <Box
-    between={3}
-    inline={false}
-    tag="div"
+  <Paragraph
+    align="left"
+    bold={false}
+    invert={false}
+    size="medium"
+  >
+    My office is where ever my customers are. TELUS helps me stay connected whether I'm making a sale or doing payroll.
+  </Paragraph>
+  <div
+    className="imageAndQuote"
   >
-    <Paragraph
-      align="left"
-      bold={false}
-      invert={false}
-      size="medium"
-    >
-      My office is where ever my customers are. TELUS helps me stay connected whether I'm making a sale or doing payroll.
-    </Paragraph>
     <div
-      className="imageAndQuote"
+      className="image"
     >
-      <div
-        className="image"
+      <Image
+        alt="Image of co-workers collaborating"
+        height={60}
+        rounded="circle"
+        src="image-example.jpg"
+        width={60}
+      />
+    </div>
+    <div>
+      <Paragraph
+        align="left"
+        bold={true}
+        invert={false}
+        size="medium"
+      >
+        Dave Smith, Foreman
+      </Paragraph>
+      <Paragraph
+        align="left"
+        bold={false}
+        invert={false}
+        size="medium"
       >
-        <Image
-          alt="Image of co-workers collaborating"
-          height={60}
-          rounded="circle"
-          src="image-example.jpg"
-          width={60}
-        />
-      </div>
-      <div>
-        <Paragraph
-          align="left"
-          bold={true}
-          invert={false}
-          size="medium"
-        >
-          Dave Smith, Foreman
-        </Paragraph>
-        <Paragraph
-          align="left"
-          bold={false}
-          invert={false}
-          size="medium"
-        >
-          Pinnacle Reforestation
-        </Paragraph>
-      </div>
+        Pinnacle Reforestation
+      </Paragraph>
     </div>
-  </Box>
-</Card>
+  </div>
+</Box>
 `;
diff --git a/packages/Testimonial/package.json b/packages/Testimonial/package.json
@@ -26,8 +26,7 @@
   },
   "dependencies": {
     "@tds/core-box": "^1.0.1",
-    "@tds/core-card": "^1.0.2",
-    "@tds/core-paragraph": "^1.0.4",
+    "@tds/core-paragraph": "^1.0.11",
     "@tds/core-responsive": "^1.1.0",
     "@tds/util-prop-types": "^1.3.2",
     "prop-types": "^15.6.2"